Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plots] plot performance degradation in vue from angular #4084

Closed
2 of 5 tasks
davetsay opened this issue Aug 4, 2021 · 2 comments · Fixed by #4092
Closed
2 of 5 tasks

[Plots] plot performance degradation in vue from angular #4084

davetsay opened this issue Aug 4, 2021 · 2 comments · Fixed by #4092
Labels
bug:regression It used to work. Now it doesn't :( performance impacts or improves performance severity:blocker target:vista-r4.8 type:bug
Projects

Comments

@davetsay
Copy link
Contributor

davetsay commented Aug 4, 2021

Summary

Plotting data (after receiving the data) takes longer in new Vue plots as it did in AngularJS plots for large data sets. UI becomes locked during plotting.

Expected vs Current Behavior

Vue plots should perform at least as well as legacy AngularJS plots

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. ensure time conductor is in fixed time mode
  2. select any plot object with decently sized data
  3. select a larger timeframe if more data needed
  4. observe time to plot
  5. expand plot to max size (maximize window size, collapse tree and inspector panes)
  6. observe time to plot
  • This was observed with identical build environments and data, but different software builds, where the vue plots lagged significantly with the high res plot.

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Additional Information

Good idea to check vue reactivity. if data is somehow being reactified.

@unlikelyzero unlikelyzero added performance impacts or improves performance severity:blocker labels Aug 5, 2021
@unlikelyzero unlikelyzero added this to Needs triage in Bug Tracker via automation Aug 5, 2021
@shefalijoshi shefalijoshi mentioned this issue Aug 6, 2021
7 tasks
Bug Tracker automation moved this from Needs triage to Closed Aug 16, 2021
@unlikelyzero
Copy link
Collaborator

@davetsay to confirm that this was tested as a part of the VISTA release verification

@davetsay
Copy link
Contributor Author

This was tested and released in VISTA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( performance impacts or improves performance severity:blocker target:vista-r4.8 type:bug
Projects
Development

Successfully merging a pull request may close this issue.

3 participants