Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Timer] Re-implement Timer object in Vue.js #4131

Closed
khalidadil opened this issue Aug 18, 2021 · 4 comments · Fixed by #4311
Closed

[Timer] Re-implement Timer object in Vue.js #4131

khalidadil opened this issue Aug 18, 2021 · 4 comments · Fixed by #4311

Comments

@khalidadil
Copy link
Contributor

The existing Timer object is currently implemented as a legacy bundle and written in Angular.js. It should be re-implemented as a plugin under /src/plugins using our current API, with the UI migrated to Vue.

Any legacy code associated with the legacy Timer object should be removed from the code-base.

@khalidadil
Copy link
Contributor Author

Testing instructions

Local Testing

If possible, create a timer in a branch before this change and then switch to the branch with the new timer. Ensure that the timer continues to display properly and that editing the properties works.

Other Testing

  1. Create a timer object and choose some values in the creation dialog. Ensure that the timer is displayed and is in the appropriate format based on the options chosen (counting up/down and correct duration shown).
  2. Edit the properties to modify the display format and ensure the timer updates with the correct format.
  3. Try pausing the timer from the context menu and make sure the timer pauses.
  4. Try stopping the timer from the context menu and make sure the timer stops and resets the display to --:--:--.
  5. Try restarting the timer from 0 from the context menu and make sure the timer restarts and starts counting up.

@unlikelyzero unlikelyzero moved this from To do to In progress in Remove AngularJS Oct 30, 2021
Remove AngularJS automation moved this from In progress to Done Nov 9, 2021
@shefalijoshi
Copy link
Contributor

Unable to test as plugin is not installed.

@charlesh88
Copy link
Contributor

Unable to verify Testathon 11-15-21

@shefalijoshi
Copy link
Contributor

Verified fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants