Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots should not request on vertical resize #4139

Closed
2 of 5 tasks
davetsay opened this issue Aug 20, 2021 · 4 comments
Closed
2 of 5 tasks

plots should not request on vertical resize #4139

davetsay opened this issue Aug 20, 2021 · 4 comments
Labels
bug:regression It used to work. Now it doesn't :( performance impacts or improves performance severity:critical type:bug
Projects

Comments

@davetsay
Copy link
Contributor

Summary

Expected vs Current Behavior

On vertical resize, plots should not make new requests for data, only on horizontal resize.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. Navigate to a plot
  2. Resize horizontally and see that new request is made (as it should)
  3. Resize vertically and see that new request is made (it should not)
  4. Bonus - get a notification to appear and see that it also acts as a window resize (maybe only on small window size)

Environment

  • Open MCT Version: 1.7.6
  • Deployment Type:
  • OS:
  • Browser:

Additional Information

@davetsay davetsay added type:bug bug:regression It used to work. Now it doesn't :( labels Aug 20, 2021
@unlikelyzero unlikelyzero added performance impacts or improves performance severity:critical labels Sep 22, 2021
@unlikelyzero unlikelyzero added this to Needs triage in Bug Tracker via automation Sep 22, 2021
@shefalijoshi
Copy link
Contributor

@davetsay @khalidadil I've tried resizing a plot vertically in it's own view and in display layouts and have not seen requests triggered.

@khalidadil
Copy link
Contributor

@davetsay I've done the same as @shefalijoshi and can't seem to reproduce this issue. Can you take a look and close it out if it's fixed?

@khalidadil khalidadil assigned davetsay and unassigned khalidadil Sep 27, 2021
@nikhilmandlik
Copy link
Contributor

@davetsay Unable to reproduce, closing.
Let test this again in testathon

Bug Tracker automation moved this from Needs triage to Done Sep 29, 2021
@nikhilmandlik
Copy link
Contributor

Verified Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( performance impacts or improves performance severity:critical type:bug
Projects
Development

No branches or pull requests

5 participants