Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence errors in Condition Sets when editing Condition Widgets #4146

Closed
1 of 5 tasks
charlesh88 opened this issue Aug 24, 2021 · 6 comments · Fixed by #4262
Closed
1 of 5 tasks

Persistence errors in Condition Sets when editing Condition Widgets #4146

charlesh88 opened this issue Aug 24, 2021 · 6 comments · Fixed by #4262

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Aug 24, 2021

Summary

Seen during Science Open MCT tagup 8-24-21. Persistence errors encountered frequently (but sporadically) and by multiple users when editing Condition Widgets that use Condition Sets for styling. Users were not able to save edited properties for the Condition Widget. Users were saving sets and widgets in their own independent folders. Trying to dupe this after the session, wasn't able to replicate.
Screen Shot 2021-08-25 at 7 34 55 AM

Expected vs Current Behavior

No errors.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. Make a Condition Set (CS) and a Condition Widget.
  2. Use the CS to conditionally style the widget. Save it.
  3. Edit properties for the widget, change the label and/or add a value into the URL field. Save.

Environment

  • Open MCT Version: 1.7.7
  • Deployment Type: /stable
  • OS:
  • Browser:

Additional Information

@akhenry
Copy link
Contributor

akhenry commented Aug 30, 2021

Condition Sets should not be mutating condition set objects unless the user has changed something.

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Sep 23, 2021

See #4254

@akhenry
Copy link
Contributor

akhenry commented Sep 23, 2021

See VIPEROMCT-60 for detailed reproduction steps.

@akhenry
Copy link
Contributor

akhenry commented Sep 23, 2021

Closed #4254 as a dupe of this one. Brought reference to JIRA issue with repro steps across as comment.

Bug Tracker automation moved this from Needs triage to Done Sep 28, 2021
@nikhilmandlik nikhilmandlik linked a pull request Sep 28, 2021 that will close this issue
8 tasks
@charlesh88
Copy link
Contributor Author

Testathon 9-28-21: verified fixed.

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon 9/28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

6 participants