Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indicators display order should be configurable #4170

Closed
davetsay opened this issue Aug 31, 2021 · 3 comments · Fixed by #4322
Closed

indicators display order should be configurable #4170

davetsay opened this issue Aug 31, 2021 · 3 comments · Fixed by #4322
Labels
type:enhancement
Milestone
Target: 1.8.1

Comments

@davetsay
Copy link
Contributor

davetsay commented Aug 31, 2021 •
edited

Overview

Indicators are displayed just based on the order in which they were installed.

Expected Behavior

The order indicators are displayed should be configurable by priority instead of order installed.

Steps to Reproduce

order of indicators before merge
image

  1. See that the order is still in the above order
@akhenry akhenry assigned scottbell and unassigned kobe1104 Oct 12, 2021
@scottbell scottbell linked a pull request Oct 15, 2021 that will close this issue
Mct4170 - Give indicators priorities #4322
Merged
8 tasks
@davetsay davetsay mentioned this issue Oct 25, 2021
Merged
8 tasks
@unlikelyzero
Copy link
Collaborator

@davetsay to add Testing Instructions

@nikhilmandlik
Copy link
Contributor

Need to test this locally.

@akhenry
Copy link
Contributor

akhenry commented Nov 15, 2021 •
edited

Verified fixed. Installed and ran locally.

  • Verified that the CLEAR DATA indicator was ordered by plugin registration.
  • Modified the priority of the indicator to HIGH and verified that it was shown first.
  • Modified the priority of the indicator to LOW and verified that it was shown last (except for the time indicator, as expected)

@unlikelyzero unlikelyzero added this to the Target: 1.8.1 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
Target: 1.8.1
Development

Successfully merging a pull request may close this issue.

Mct4170 - Give indicators priorities nasa/openmct
7 participants
@nikhilmandlik @davetsay @akhenry @shefalijoshi @scottbell @unlikelyzero @kobe1104