Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Display Layout] Grid disappearing when scrolling down (in Edit Mode) #4207

Closed
1 of 5 tasks
jvigliotta opened this issue Sep 10, 2021 · 10 comments · Fixed by #4366
Closed
1 of 5 tasks

[Display Layout] Grid disappearing when scrolling down (in Edit Mode) #4207

jvigliotta opened this issue Sep 10, 2021 · 10 comments · Fixed by #4366
Labels
bug:visual Visual problem. Not a functional issue type:bug
Milestone

Comments

@jvigliotta
Copy link
Contributor

jvigliotta commented Sep 10, 2021

Summary

When editing a display layout, if you move an object down lower and the layout has to scroll, the grid background just stops. Possibly new area being added doesn't have css applied?

Expected vs Current Behavior

Grid should show.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. Created a dislpay layout
  2. Drag an object below the current view, so you have to scroll
  3. Grid doesn't continue to that area

Additional Information

Screen Shot 2021-09-10 at 2 24 48 PM

@jvigliotta jvigliotta added type:bug bug:visual Visual problem. Not a functional issue low-priority labels Sep 10, 2021
@imrishabh18
Copy link

@jvigliotta Can I take up this issue? I am new to this will be needing your help with this 😁

@jvigliotta
Copy link
Contributor Author

hi @imrishabh18! Have you filled out one of our CLA's yet? If not you can follow the steps here: #3821

@charlesh88 is this still an issue? I thought I saw a PR/Issue that was similar?

@depperm
Copy link
Contributor

depperm commented Oct 23, 2021

I've also looked into this and believe I have a fix. I've emailed my CLA in and just waiting access to the repo to push.

@depperm depperm mentioned this issue Oct 25, 2021
8 tasks
@charlesh88
Copy link
Contributor

For clarity:

  1. This is not the same as Display Layout snapping grid not displaying while editing #4299.
  2. The problem here is that the size of the workspace (conceptually) and therefore the grid holder needs to be infinite. In reality, it's the initial size of the workspace. When a user moves an object beyond the right or bottom edges of the workspace, they effectively "increase" the workspace size - but nothing tells the grid holder this as occurred, and it never resizes.

Screen Shot 2021-10-26 at 11 06 02 AM

@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 11/15/2021

@shefalijoshi
Copy link
Contributor

Verified fixed.

@charlesh88
Copy link
Contributor

Verified fixed Testathon 11-15-2021

@kobe1104
Copy link
Contributor

Verified fixed testathon 11/15/2021.

@davetsay
Copy link
Contributor

when i expand the window horizontally, to the right, the same non-grid behavior exists.

@unlikelyzero unlikelyzero added this to the Target: 1.8.1 milestone Nov 15, 2021
@nikhilmandlik
Copy link
Contributor

created related new issue: #4467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:visual Visual problem. Not a functional issue type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants