Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time Conductor] Pan/Zoom causes duplicate bounds events #4294

Closed
1 of 5 tasks
jvigliotta opened this issue Oct 6, 2021 · 1 comment · Fixed by #4295
Closed
1 of 5 tasks

[Time Conductor] Pan/Zoom causes duplicate bounds events #4294

jvigliotta opened this issue Oct 6, 2021 · 1 comment · Fixed by #4295

Comments

@jvigliotta
Copy link
Contributor

jvigliotta commented Oct 6, 2021

Summary

Pan/Zoom on conductor causes two bounds events to be emitted, resulting in double requests for views listening to those events.

This is due to zoom/pan being calculated based off of width of selection, which can result in decimal timestamps. The solution would be to normalize those measurements before setting the bounds with them.

Expected vs Current Behavior

One request should be made when panning or zooming on the conductor.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. View telemetry with network tab open
  2. If you zoom or pan on the conductor time axis two duplicate requests are being made

Testing

This should only be one reqeust.

@jvigliotta jvigliotta self-assigned this Oct 6, 2021
@jvigliotta jvigliotta mentioned this issue Oct 6, 2021
8 tasks
@unlikelyzero unlikelyzero added this to Needs triage in Bug Tracker via automation Oct 8, 2021
@unlikelyzero unlikelyzero moved this from Needs triage to Done in Bug Tracker Oct 8, 2021
@khalidadil khalidadil self-assigned this Oct 8, 2021
@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 10/08/2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

4 participants