Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrubbing and zooming the time conductor should update the start and end inputs in real time #4352

Closed
2 of 5 tasks
akhenry opened this issue Oct 22, 2021 · 6 comments · Fixed by #4877
Closed
2 of 5 tasks
Labels
bug:regression It used to work. Now it doesn't :( help_wanted Help the Open MCT project! needs:e2e Needs an e2e test severity:critical type:bug

Comments

@akhenry
Copy link
Contributor

akhenry commented Oct 22, 2021

Summary

When scrubbing or zooming the time conductor, the values in the start and end inputs should update in realtime. Note that the bounds in the time API should not update until the user has released the mouse.

This is a very recent regression and might be related to the independent time conductor changes.

Screen Recording 2021-10-22 at 1 50 01 PM

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. Switch to fixed time mode
  2. Hold the option key (mac) and drag the time conductor axis left and right
  3. Observe that the input values for the start and end time do not change until the mouse is released

Environment

  • Open MCT Version: 1.7.8
  • OS: All
  • Browser: All
@akhenry akhenry added type:bug severity:critical bug:regression It used to work. Now it doesn't :( labels Oct 22, 2021
@unlikelyzero unlikelyzero added this to Needs triage in Bug Tracker via automation Nov 1, 2021
@shefalijoshi
Copy link
Contributor

shefalijoshi commented Dec 13, 2021

This appears to be working in testathon. Closing.

Bug Tracker automation moved this from Needs triage to Done Dec 13, 2021
@akhenry akhenry reopened this Dec 13, 2021
Bug Tracker automation moved this from Done to Needs triage Dec 13, 2021
@akhenry
Copy link
Contributor Author

akhenry commented Dec 13, 2021

It's not working on testathon. The start and end dates should change in real time as the conductor is scrubbed. Right now they only change after you release the mouse button.

@akhenry
Copy link
Contributor Author

akhenry commented Dec 13, 2021

Here's a comparison of the "panning" (or "scrubbing") behavior from two different versions:

1.7.8

1 7 8

1.8.1 (Testathon)

testathon

@akhenry
Copy link
Contributor Author

akhenry commented Dec 13, 2021

It's important to note that the value of the inputs changes as you drag, but the Time API bounds do not update until the mouse is released. It was all being done via events that were internal to the Time Conductor component, the Time API does not get involved until the user releases the mouse button.

I believe that the intended behavior was lost during refactoring for independent time conductors.

@akhenry akhenry moved this from Needs triage to Will Do in Bug Tracker Dec 13, 2021
@shefalijoshi
Copy link
Contributor

Testing Instructions:
Pan and zoom the time conductor and ensure that the input fields update accordingly

Bug Tracker automation moved this from Will Do to Done Mar 21, 2022
@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Mar 23, 2022
@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation Mar 23, 2022
@unlikelyzero
Copy link
Collaborator

Verified fixed

@unlikelyzero unlikelyzero added the help_wanted Help the Open MCT project! label May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( help_wanted Help the Open MCT project! needs:e2e Needs an e2e test severity:critical type:bug
Development

Successfully merging a pull request may close this issue.

3 participants