Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Telemetry Request Abort #4361

Closed
davetsay opened this issue Oct 24, 2021 · 6 comments · Fixed by #4504
Closed

Implement Telemetry Request Abort #4361

davetsay opened this issue Oct 24, 2021 · 6 comments · Fixed by #4504

Comments

@davetsay
Copy link
Contributor

davetsay commented Oct 24, 2021

Is your feature request related to a problem? Please describe.
Clicking multiple views in succession will continue to queue up requests, even if the view has been destroyed and the requests are not needed anymore. If enough requests are queued up the UI becomes unusable.

Describe the solution you'd like
Implement abort in views

Additional context
There should be partial implementation already.

VISTA ticket: https://github.jpl.nasa.gov/MissionControl/vista/issues/964

@akhenry
Copy link
Contributor

akhenry commented Nov 1, 2021

I would like to see this implemented in the API if possible, so that we don't have to put a lot of boilerplate in individual views. On navigation the telemetry API could automatically abort the request and reject the promise. That way, our views would only need to handle rejected promises (which they should anyway) and would not need specific handling for handling abort.

The Telemetry API would just need to manage an AbortController and pass it down to the telemetry providers along with the passed in arguments. We will need to modify the telemetry provider interface slightly to include an optional abort controller. We should make sure that the public documentation gets updated when we do this.

To detect navigation the telemetry API could listen to the ApplicationRouter's 'change:path'.

@akhenry akhenry changed the title implement request abort Implement request abort Nov 1, 2021
@akhenry akhenry changed the title Implement request abort Implement Telemetry Request Abort Nov 1, 2021
@khalidadil
Copy link
Contributor

Testing instructions:

  1. Open a domainObject with telemetry on banner.
  2. Open devtools and the network tab.
  3. Navigate to another domainObject. You should see the old telemetry request has been aborted.

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon: 12/13/2021

Any existing telemetry requests were canceled.

@kobe1104
Copy link
Contributor

Verified fixed - testathon 12/13/2021

@charlesh88
Copy link
Contributor

charlesh88 commented Dec 13, 2021

Verified fixed Testathon 12-13-21.

image

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

@unlikelyzero unlikelyzero added this to the Target: 1.8.3 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants