Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"My Items" interceptor test failing #4476

Closed
1 of 5 tasks
scottbell opened this issue Nov 18, 2021 · 1 comment
Closed
1 of 5 tasks

"My Items" interceptor test failing #4476

scottbell opened this issue Nov 18, 2021 · 1 comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
Milestone

Comments

@scottbell
Copy link
Contributor

Summary

This test appears to be failing in its cleanup:
https://github.com/nasa/openmct/blob/master/src/plugins/myItems/pluginSpec.js#L82

Here's the output from the daily build:
https://app.circleci.com/pipelines/github/nasa/openmct/7078/workflows/39881ff1-24c2-4914-8bf5-ae894c540829/jobs/19835

the plugin
    ✓ when installed, adds "My Items" to the root (39ms)
    adds an interceptor that returns a "My Items" model for
      ✓ missing objects (61ms)
Chrome Headless 96.0.4664.45 (Linux x86_64) ERROR
  An error was thrown in afterAll
  Unhandled promise rejection: Object provider does not support saving thrown
Chrome Headless 96.0.4664.45 (Linux x86_64) ERROR
  An error was thrown in afterAll
  Unhandled promise rejection: Object provider does not support saving thrown

I think it was caused by this PR:
#4471

Note the test sometimes passes, so it appears to be a timing error.

Expected vs Current Behavior

The test should consistently pass.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. git checkout master
  2. npm run test
  3. Observe the test failure
  4. If the test does not fail, repeat step 3 until it does.

Environment

  • Open MCT Version: master
  • Deployment Type: npm dev
  • OS: Linux/Windows
  • Browser: Chrome Headless
@unlikelyzero unlikelyzero added this to Needs triage in Bug Tracker via automation Nov 19, 2021
@unlikelyzero unlikelyzero added type:maintenance tests, chores, or project maintenance and removed type:bug labels Nov 19, 2021
@unlikelyzero unlikelyzero added this to the Target: 1.8.1 milestone Nov 19, 2021
@shefalijoshi
Copy link
Contributor

This is fixed as part of #4310, but in master. That said, I think it's ok to close this for 1.8.1

Bug Tracker automation moved this from Needs triage to Done Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
Development

No branches or pull requests

3 participants