Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WorkerService is no longer needed #4482

Closed
davetsay opened this issue Nov 18, 2021 · 5 comments · Fixed by #4484
Closed

WorkerService is no longer needed #4482

davetsay opened this issue Nov 18, 2021 · 5 comments · Fixed by #4484
Labels
target:vista-r4.9 type:enhancement
Milestone
Target: 1.8.3

Comments

@davetsay
Copy link
Contributor

davetsay commented Nov 18, 2021 •
edited

Overview

Refactor to remove AngularJS. No current benefit in tracking workers in api so removing altogether.

Expected Behavior

Anything using WorkerService (using Web Workers) should still work.

  • Bare Bones Search (fallback search not provided by objectProvider) should still work.

Steps to Reproduce

  1. Do a search for an object that isn't provided by an ObjectProvider and see that it returns a result
  2. Ex. For a VIPER deployment, VIPER Plans will satisfy this condition
@mariuszr mariuszr mentioned this issue Nov 21, 2021
Merged
7 tasks
@davetsay davetsay changed the title Should convert WorkerService to WorkerAPI WorkerService is no longer needed Nov 29, 2021
@davetsay davetsay self-assigned this Nov 29, 2021
@unlikelyzero unlikelyzero added this to the Target: 1.8.2 milestone Dec 13, 2021
@charlesh88 charlesh88 added the needs:test instructions Missing testing notes label Dec 13, 2021
@charlesh88
Copy link
Contributor

Testathon 12-13-21: needs testing notes, not sure how to find an object that isn't provided by an ObjectProvider.

@khalidadil
Copy link
Contributor

I was able to search for "Plan 5" under VIPER Plans on Banner Testathon, and it returned "Plan 5" as a search result. Does that confirm this is working @davetsay?

@unlikelyzero
Copy link
Collaborator

Testing Notes

On banner just search for plans and see that viper plans comes up

@unlikelyzero unlikelyzero assigned shefalijoshi and unassigned davetsay Jan 6, 2022
@charlesh88
Copy link
Contributor

Verified fixed Testathon 01-06-22.

@shefalijoshi
Copy link
Contributor

Verified fixed

@unlikelyzero unlikelyzero removed the needs:test instructions Missing testing notes label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
target:vista-r4.9 type:enhancement
Projects
None yet
Milestone
Target: 1.8.3
Development

Successfully merging a pull request may close this issue.

remove WorkerService nasa/openmct
6 participants
@charlesh88 @khalidadil @davetsay @akhenry @shefalijoshi @unlikelyzero