Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace legacy format service #4530

Closed
akhenry opened this issue Dec 3, 2021 · 2 comments · Fixed by #4531
Closed

Replace legacy format service #4530

akhenry opened this issue Dec 3, 2021 · 2 comments · Fixed by #4531
Labels
type:maintenance tests, chores, or project maintenance
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Dec 3, 2021

Summary

The formatting API currently relies on Angular managed services behind the scenes. As part of our effort to remove Angular 1.x the legacy format service needs to be retired and replaced with a vanilla JavaScript solution.

Deprecation Notice

This will complete remove support for legacy format registration. The interface of our formatter classes has not changed, only the method of registration. Any code still using legacy format registration should switch to using our current format registration API.

@akhenry
Copy link
Contributor Author

akhenry commented Dec 4, 2021

Testing Notes

This issue affects existing functionality only, so there is no new functionality to test. Instead testers should verify that formatting is still working as expected.

  1. Open a plot and verify that X-axis timestamps are rendering correctly
  2. Open a table and verify that both telemetry values and timestamps are rendering correctly.
  3. Open a LAD Table and verify that both telemetry values and time stamps are rendering correctly.

@shefalijoshi
Copy link
Contributor

Verified Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants