Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Ignore tests in codecov reporting #4549

Closed
unlikelyzero opened this issue Dec 8, 2021 · 2 comments · Fixed by #4548 or #4550
Closed

[CI] Ignore tests in codecov reporting #4549

unlikelyzero opened this issue Dec 8, 2021 · 2 comments · Fixed by #4548 or #4550
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target: 1.8.2

Comments

@unlikelyzero
Copy link
Collaborator

Summary

Right now, codecov is picking up parts of Spec files which is missing coverage. This is interesting but not applicable for our team.

We should ignore the test filetype so that the github inline codecov notes don't appear.

Testing Notes

Open or find a PR which modifies a Spec file
Verify that the Spec file does not contain any comments from codecov patch
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Dec 8, 2021
@unlikelyzero unlikelyzero mentioned this issue Dec 8, 2021
Merged
8 tasks
@unlikelyzero unlikelyzero added this to the Target: 1.8.2 milestone Dec 8, 2021
@unlikelyzero unlikelyzero linked a pull request Dec 8, 2021 that will close this issue
String in our yaml #4550
Merged
8 tasks
@unlikelyzero unlikelyzero mentioned this issue Dec 8, 2021
Merged
8 tasks
@unlikelyzero
Copy link
Collaborator Author

Testing Notes
Open or find a PR which modifies a Spec file
Verify that the Spec file does not contain any comments from codecov patch

@khalidadil
Copy link
Contributor

Looking at this PR, this looks good. (Testathon on 12/13/2021)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target: 1.8.2
Development

Successfully merging a pull request may close this issue.

Ignore tests in codecov nasa/openmct
String in our yaml nasa/openmct
3 participants
@khalidadil @shefalijoshi @unlikelyzero