Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import from Json] Imported options need to have the File Selector clicked twice to Import #4561

Closed
4 of 5 tasks
unlikelyzero opened this issue Dec 10, 2021 · 5 comments
Closed
4 of 5 tasks

Comments

@unlikelyzero
Copy link
Collaborator

Summary

This fixed the import JSON action #4470 , but in the current implementation, the File Selector must be clicked a second time to import the object

Expected vs Current Behavior

Objects should import on first use of File Selection. Instead, domain objects are imported on second use of File Selection button.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. Export a Domain Object as JSON as "ObjectA"
  2. Import a Domain Object as JSON either with the kebob or tree options
  3. On 'Import as JSON modal, click the 'Select File...' button and select "ObjectA"
  4. Note that the 'Ok' button in not actionable
  5. Click on the 'Select File...' button again, but do not make a selection
    Note: Can now import as JSON

Environment

  • Open MCT Version: 1.8.1
  • Deployment Type: npm

Additional Information

Screen Recording 2021-12-10 at 02 44 41 PM

@unlikelyzero
Copy link
Collaborator Author

Marking as fixed in #4478 to verify in testathon

@unlikelyzero
Copy link
Collaborator Author

Testing Notes

  1. Export a Domain Object as JSON as "ObjectA"
  2. Import a Domain Object as JSON either with the kebob or tree options
  3. On 'Import as JSON modal, click the 'Select File...' button and select "ObjectA"
  4. ObjectA Is imported and available on the Tree

@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 12/13/2021

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon: 12/13/2021

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants