Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of the IdentifierService from any non-legacy code #4590

Closed
akhenry opened this issue Dec 15, 2021 · 4 comments · Fixed by #4583
Closed

Remove usage of the IdentifierService from any non-legacy code #4590

akhenry opened this issue Dec 15, 2021 · 4 comments · Fixed by #4583

Comments

@akhenry
Copy link
Contributor

akhenry commented Dec 15, 2021

Summary

The IdenfitierService is doing translation between persistence spaces and namespaces. This distinction has never been supported by our modern API and was deprecated years ago.

This change may cause compatibility issues for any legacy custom persistence providers that were implicitly relying on the identifierService to perform translations between the '' and 'mct' namespaces. If this is the case, it is recommended that plugins are updated to use the current Open MCT API, which requires a single unambiguous namespace to be specified.

Any database-specific compatibility issues with existing data that may use a mixture of namespaces (as Couch did) should be handled in the plugin itself. The Open MCT Couch DB plugin can be used as an example.

@akhenry akhenry added the type:maintenance tests, chores, or project maintenance label Dec 15, 2021
@akhenry
Copy link
Contributor Author

akhenry commented Dec 16, 2021

Testing Notes

This involves no new features but does affect the fundamental functioning of the Object API and the Couch DB adapter.

  • Verify that the tree is being populated with objects from Couch DB,
  • Verify that new Couch DB objects can be created,
  • Verify that existing Couch DB objects can be modified,
  • Verify that existing Couch DB objects can be deleted.

@shefalijoshi
Copy link
Contributor

Unable to create new objects, but that might be a side-effect of #4615

@unlikelyzero unlikelyzero reopened this Jan 4, 2022
@unlikelyzero unlikelyzero added type:enhancement and removed type:maintenance tests, chores, or project maintenance labels Jan 4, 2022
@shefalijoshi
Copy link
Contributor

Apart from the LegacyObjectAPIInterceptor.js, it appears that identifierService is not being used in any non-legacy code.
Closing.

@michaelrogers
Copy link
Contributor

michaelrogers commented Jan 6, 2022

Verified change during Testathon 2022-01-06 on release/1.8.3.

Observed populated tree, created a new domain object and modified and deleted existing domain objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants