Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Update Circle CI branch protection rules for 1.8.3 to match the overall circleci check #4596

Closed
unlikelyzero opened this issue Dec 16, 2021 · 3 comments
Closed

[CI] Update Circle CI branch protection rules for 1.8.3 to match the overall circleci check #4596

unlikelyzero opened this issue Dec 16, 2021 · 3 comments
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target: 1.8.3

Comments

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Dec 16, 2021 •
edited

Summary

need to update the circle ci branch protection rules for 1.8.3 to match this name

openmct/.circleci/config.yml

Line 142 in 1f588a2

overall-circleci-commit-status: #These jobs run on every commit

@unlikelyzero unlikelyzero added type:maintenance tests, chores, or project maintenance Target:1.8.3 labels Dec 16, 2021
@unlikelyzero unlikelyzero added this to the Target: 1.8.3 milestone Dec 16, 2021
@unlikelyzero
Copy link
Collaborator Author

Testing Notes

Create a PR against the release/1.8.3 branch with broken tests and verify that you cannot merge

@akhenry akhenry mentioned this issue Jan 6, 2022
Closed
3 tasks
@akhenry
Copy link
Contributor

akhenry commented Jan 6, 2022

Verified fixed by #4685

Screen Shot 2022-01-06 at 3 16 54 PM

@akhenry
Copy link
Contributor

akhenry commented Jan 6, 2022

That screenshot is not going to cause confusion...

@akhenry akhenry removed the unverified label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target: 1.8.3
Development

No branches or pull requests
2 participants
@akhenry @unlikelyzero