Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Invert npmignore file to reduce complexity #4641

Closed
unlikelyzero opened this issue Dec 30, 2021 · 3 comments · Fixed by #4605
Closed

[build] Invert npmignore file to reduce complexity #4641

unlikelyzero opened this issue Dec 30, 2021 · 3 comments · Fixed by #4605
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target:2.0.2

Comments

@unlikelyzero
Copy link
Collaborator

Summary

There is a new pattern for npmignore files which inverts the file to an allowlist instead of a blocklist.
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Dec 30, 2021
@unlikelyzero
Copy link
Collaborator Author

Testing Notes

run npm pack
verify that only the specified files are included

@unlikelyzero unlikelyzero mentioned this issue Dec 30, 2021
Merged
15 tasks
@trusktr
Copy link
Contributor

trusktr commented Mar 22, 2022

To test #4605, use npm pack to create a tar file, then verify the contents.

@khalidadil
Copy link
Contributor

I believe this is good now. I'm seeing only the folders src/dist/example in the zip file, and all test files have been removed as far as I can tell. Testathon on 04/04/2022

@unlikelyzero unlikelyzero added this to the Target:2.0.2 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target:2.0.2
Development

Successfully merging a pull request may close this issue.

invert npmignore to include what we want nasa/openmct
4 participants
@trusktr @khalidadil @shefalijoshi @unlikelyzero