Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Update eslint and eslint-vue packages and enforce new rules #4659

Closed
unlikelyzero opened this issue Jan 3, 2022 · 4 comments
Closed

[build] Update eslint and eslint-vue packages and enforce new rules #4659

unlikelyzero opened this issue Jan 3, 2022 · 4 comments
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target:2.0.2

Comments

@unlikelyzero
Copy link
Collaborator

Summary

Currently we're on eslint 7.x and 8.6 is the latest. Less than zero engineering effort is required to get us onto eslint 8.x and the latest vue linting rules.
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Jan 3, 2022
@unlikelyzero
Copy link
Collaborator Author

#4546
and
#4554
and
#4650
all attempt to upgrade these dependencies.

Will close #2449

@unlikelyzero unlikelyzero changed the title [build] Update eslint and eslint-vue rules [build] Update eslint and eslint-vue packages and enforce new rules Jan 4, 2022
@trusktr trusktr mentioned this issue Jan 13, 2022
Merged
15 tasks
@unlikelyzero
Copy link
Collaborator Author

closed by #4670

@unlikelyzero unlikelyzero added the needs:test instructions Missing testing notes label Mar 21, 2022
@unlikelyzero
Copy link
Collaborator Author

@trusktr can you add some testing notes? Something that would give another developer context on your specific changes and also ensure that they understand what you may have missed in your first implementation?

@khalidadil
Copy link
Contributor

When running npm run lint, I'm seeing 4 warnings and no errors. OpenMCT seems to start normally, but I haven't dug too deep. Testathon on 04/04/2022

@unlikelyzero unlikelyzero added this to the Target:2.0.2 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target:2.0.2
Development

No branches or pull requests
3 participants
@trusktr @khalidadil @unlikelyzero