Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type annotations #4793

Closed
trusktr opened this issue Jan 26, 2022 · 3 comments · Fixed by #4789
Closed

add type annotations #4793

trusktr opened this issue Jan 26, 2022 · 3 comments · Fixed by #4789
Labels
type:maintenance tests, chores, or project maintenance
Milestone

Comments

@trusktr
Copy link
Contributor

trusktr commented Jan 26, 2022

Summary

Add some type annotations (#4789)

The behavior of the app shouldn't change (unless I goofed something), so there's nothing to test specifically, just that the app works.

Testing notes:

  • if you use TypeScript and you open the source in your IDE, and your IDE is configured for TypeScript, this helps you see things such as informational tooltips when hovering on identifiers, autocompletion of possible values, parameter hints, etc.
  • As far as OpenMCT itself, there is no change to behavior, nothing to test as far as functionality. If you haven't been using TypeScript intellisense, you'll notice no difference in your editing experience (apart from seeing additional comments in the source code, which you should strive to keep up-to-date if you modify any APIs).
@trusktr trusktr added the type:maintenance tests, chores, or project maintenance label Jan 26, 2022
@trusktr trusktr mentioned this issue Jan 26, 2022
15 tasks
@shefalijoshi
Copy link
Contributor

@trusktr Please add some test instructions.

@unlikelyzero
Copy link
Collaborator

Testing notes:

if you use TypeScript and you open the source in your IDE, and your IDE is configured for TypeScript, this helps you see things such as informational tooltips when hovering on identifiers, autocompletion of possible values, parameter hints, etc.
As far as OpenMCT itself, there is no change to behavior, nothing to test as far as functionality. If you haven't been using TypeScript intellisense, you'll notice no difference in your editing experience (apart from seeing additional comments in the source code, which you should strive to keep up-to-date if you modify any APIs).

@unlikelyzero
Copy link
Collaborator

Will cover in demo day

@unlikelyzero unlikelyzero added this to the Target:2.0.2 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants