Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] npm run clean script references absolute path instead of relative for node_modules #4800

Closed
unlikelyzero opened this issue Jan 27, 2022 · 2 comments · Fixed by #4801
Closed

[Build] npm run clean script references absolute path instead of relative for node_modules #4800

unlikelyzero opened this issue Jan 27, 2022 · 2 comments · Fixed by #4801
Labels
type:maintenance tests, chores, or project maintenance

Comments

@unlikelyzero
Copy link
Collaborator

Summary

npm run clean is designed to clean the dist and node_modules folder. With the current implementation, it uses a relative path for ./dist but an absolute path /node_modules . Effectively, this means that node_modules are not cleaned on personal devices.
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Jan 27, 2022
@unlikelyzero unlikelyzero mentioned this issue Jan 27, 2022
Merged
15 tasks
@unlikelyzero
Copy link
Collaborator Author

Testing Notes

npm install;npm run clean on any branch other than master (after this change). Note that node_modules folder persists
npm install;npm run clean after switching to a branch with this change. Note that node_modules folder is cleaned

@michaelrogers
Copy link
Contributor

Fix working as expected and verified in testathon 2022-02-17.

@michaelrogers michaelrogers removed their assignment Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Build] npm run clean uses absolute path instead of relative for node_modules nasa/openmct
2 participants
@michaelrogers @unlikelyzero