Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Remove Support for Node12 after EOL #4872

Closed
unlikelyzero opened this issue Feb 16, 2022 · 2 comments · Fixed by #4963
Closed

[Build] Remove Support for Node12 after EOL #4872

unlikelyzero opened this issue Feb 16, 2022 · 2 comments · Fixed by #4963
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target:2.0.2

Comments

@unlikelyzero
Copy link
Collaborator

Summary

Node12 hits EOL on April. Once that happens, we should:

  • Add lighthouse to our dependencies
  • Update our package.json engine: check
  • More to come
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Feb 16, 2022
@unlikelyzero unlikelyzero mentioned this issue Feb 16, 2022
Merged
15 tasks
@unlikelyzero unlikelyzero mentioned this issue Mar 22, 2022
Merged
15 tasks
@unlikelyzero
Copy link
Collaborator Author

Testing Notes

nvm use 12;npm install should fail
nvm use 14;npm install should succeed

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Apr 4, 2022 •
edited

Verified fixed. I did need to upgrade from 14.18.x to 14.19.1 though.

@unlikelyzero unlikelyzero added this to the Target:2.0.2 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target:2.0.2
Development

Successfully merging a pull request may close this issue.

[Build] Remove testing and support for node12 nasa/openmct
2 participants
@shefalijoshi @unlikelyzero