Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NonEditableFolder plugin #4899

Closed
jvigliotta opened this issue Feb 25, 2022 · 6 comments · Fixed by #4898
Closed

Remove NonEditableFolder plugin #4899

jvigliotta opened this issue Feb 25, 2022 · 6 comments · Fixed by #4898
Labels
bug:retest Retest without a specific milestone type:enhancement

Comments

@jvigliotta
Copy link
Contributor

jvigliotta commented Feb 25, 2022 •
edited

Is your feature request related to a problem? Please describe.
Related to persistence vs creatability updates.

Describe the solution you'd like
Have persistence be determined by object providers.

Describe alternatives you've considered
This was the alternative... now it's not necessary.

Additional context
Directly related to:
akhenry/openmct-yamcs#113
#4323
#3741

Testing notes in: akhenry/openmct-yamcs#113
@jvigliotta jvigliotta mentioned this issue Feb 25, 2022
Closed
@jvigliotta jvigliotta self-assigned this Feb 25, 2022
@jvigliotta jvigliotta mentioned this issue Feb 25, 2022
Merged
15 tasks
@unlikelyzero
Copy link
Collaborator

Testing Notes
on previous noneditable folder types, "VIPER" (and child folders) and "VIPER Plans", check you cannot edit or modify
you SHOULD be able to still link these items

@unlikelyzero unlikelyzero removed the needs:test instructions Missing testing notes label Mar 14, 2022
@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Mar 14, 2022 •
edited

Verified:

Clock object cannot be attached to Objects like VIPER Plans or VIPER objects

@unlikelyzero
Copy link
Collaborator

Re-opening because it's not possible to link a VIPER Plan to a Shared Items object view

@unlikelyzero unlikelyzero reopened this Mar 15, 2022
@unlikelyzero unlikelyzero mentioned this issue Mar 17, 2022
Merged
15 tasks
@unlikelyzero unlikelyzero added Target:2.0.4 bug:retest Retest without a specific milestone and removed Target:2.0.1 labels May 3, 2022
@davetsay
Copy link
Contributor

davetsay commented Jun 9, 2022

filed this issue, #5320

@khalidadil
Copy link
Contributor

khalidadil commented Jun 27, 2022 •
edited

I'm able create a link to the Day 1 plan to my folder in Shared Items, but I can also edit the name of the Day 1 plan. I'm not sure if I should close this or not. @jvigliotta?

@unlikelyzero
Copy link
Collaborator

Plans are a unicorn. We can close this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:retest Retest without a specific milestone type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly use creatable attribute and persistability when working with domainObjects nasa/openmct
5 participants
@khalidadil @davetsay @akhenry @jvigliotta @unlikelyzero