Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot x-axis getting cut off in display layout #4902

Closed
3 of 5 tasks
shefalijoshi opened this issue Mar 1, 2022 · 4 comments · Fixed by #4903
Closed
3 of 5 tasks

Plot x-axis getting cut off in display layout #4902

shefalijoshi opened this issue Mar 1, 2022 · 4 comments · Fixed by #4903
Labels
help_wanted Help the Open MCT project! needs:e2e Needs an e2e test severity:blocker type:bug

Comments

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Mar 1, 2022

Summary

Plot x-axis getting cut off in display layout - this makes it impossible to see x-axis ticks.

Expected vs Current Behavior

X axis should be completely visible

Steps to Reproduce

  1. Create a plot
    2.Create a display layout
    3.Add the plot to the display layout
    4.Observe that the x-axis is cut off

Environment

  • Open MCT Version: 2.0.1-SNAPSHOT
  • Deployment Type: local
  • OS: Mac
  • Browser: Firefox

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?

Additional Information

image

@shefalijoshi
Copy link
Contributor Author

Testing notes
Add a plot to the display layout
Ensure that the x-axis is being displayed correctly.

@charlesh88
Copy link
Contributor

charlesh88 commented Mar 17, 2022

Testathon 3-17-22: verified fixed.

@charlesh88 charlesh88 self-assigned this Mar 17, 2022
@nikhilmandlik
Copy link
Contributor

Verified Fixed.

@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Mar 17, 2022
@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation Mar 17, 2022
@unlikelyzero unlikelyzero moved this from To triage to Ready! in Improve Test Coverage Mar 17, 2022
@unlikelyzero unlikelyzero added help_wanted Help the Open MCT project! source:community Community contribution or request and removed source:community Community contribution or request labels May 3, 2022
@unlikelyzero
Copy link
Collaborator

Note for e2e test additions: this will require a visual test.

Default.visual.e2e.spec.js

//Psuedo-code as comments
//Create a Display Layout
//Create a SineWave Generator
//Move SineWave Generator into Display Layout
//Reload Display Layout in Read-only Mode
percy.snapshot('Sinewave Generator in Display Layout - Read-only');
//Open Display Layout in Edit mode
percy.snapshot('Sinewave Generator in Display Layout - Edit-only'):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help_wanted Help the Open MCT project! needs:e2e Needs an e2e test severity:blocker type:bug
Projects
Development

Successfully merging a pull request may close this issue.

5 participants