Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Inline linting warnings are extremely noisy on pr:platform workflow #4909

Closed
unlikelyzero opened this issue Mar 3, 2022 · 2 comments · Fixed by #4906
Closed

[CI] Inline linting warnings are extremely noisy on pr:platform workflow #4909

unlikelyzero opened this issue Mar 3, 2022 · 2 comments · Fixed by #4906
Labels
type:maintenance tests, chores, or project maintenance

Comments

@unlikelyzero
Copy link
Collaborator

Summary

When a linting warning is found on pr:platform workflows, it results in a ton of inline warnings (1 per component in the matrix). We should remove those linting warnings altogether as the purpose of the linting is only to fail without inline help.
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Mar 3, 2022
@unlikelyzero unlikelyzero mentioned this issue Mar 3, 2022
Merged
15 tasks
@unlikelyzero
Copy link
Collaborator Author

Test instructions

  1. Open a PR
  2. Add a pr:platform label to a PR
  3. Wait for matrix to complete
  4. Verify that no in-line help is generated on the 'Files' Part of the PR

@jvigliotta
Copy link
Contributor

Confirmed Fixed - Testathon 3/14/2022

@unlikelyzero unlikelyzero mentioned this issue Aug 23, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] Remove warning output for eslint on platform workflow nasa/openmct
2 participants
@jvigliotta @unlikelyzero