Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Memory Search performance and namespacing issues #4946

Closed
2 tasks done
davetsay opened this issue Mar 16, 2022 · 2 comments · Fixed by #4947
Closed
2 tasks done

In Memory Search performance and namespacing issues #4946

davetsay opened this issue Mar 16, 2022 · 2 comments · Fixed by #4947
Assignees
Labels
bug:regression It used to work. Now it doesn't :( performance impacts or improves performance severity:critical type:bug

Comments

@davetsay
Copy link
Contributor

Summary

  • in memory search re-indexes on every tree expansion (even same node)
  • in memory search does not work for namespaces

Expected vs Current Behavior

Each object should be indexed once on load. Objects should be re-indexed only on name change or composition change.

Steps to Reproduce

Over-indexing

  1. Load Open MCT
  2. Open console browser and open source file inMemorySearchProvider.js
  3. Set a break point in the index function definition
  4. expand a node in the object tree
  5. Expect code does not stop at set breakpoint

No Namespacing

  1. Gain access to deployment with namespaces
  2. Test search

Environment

  • Open MCT Version: 2.0.1
  • Deployment Type: VISTA to test namespacing
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • [] Is there a workaround available?
  • [] Does this impact a critical component?
  • [] Is this just a visual bug with no functional impact?

Additional Information

@davetsay
Copy link
Contributor Author

davetsay commented Apr 22, 2022

For what its worth, I verified the No Namespacing part is fixed in Open MCT for MCWS

@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 04/25/2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( performance impacts or improves performance severity:critical type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants