Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Add support for node18 #4964

Closed
4 of 7 tasks
unlikelyzero opened this issue Mar 22, 2022 · 3 comments · Fixed by #5091
Closed
4 of 7 tasks

[Build] Add support for node18 #4964

unlikelyzero opened this issue Mar 22, 2022 · 3 comments · Fixed by #5091
Labels
type:maintenance tests, chores, or project maintenance

Comments

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Mar 22, 2022

Summary

Node 18 should be released on April 18. We should enable it in:

  • CircleCI
  • 'overall-commit-status'
  • 'the-nightly'
  • GHA
  • 'pr:platform'
  • 'pr:e2e'
  • 'pr:visual'
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Mar 22, 2022
@unlikelyzero unlikelyzero mentioned this issue Mar 30, 2022
20 tasks
@unlikelyzero
Copy link
Collaborator Author

Testing Notes

nvm install 18;npm install;npm test

@michaelrogers
Copy link
Contributor

Verified in testathon 04/25/2022.

@jvigliotta
Copy link
Contributor

Verified @michaelrogers verification: 04/25/2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants