Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Move off of all unnecessary loaders for webpack 5 #5007

Closed
4 of 14 tasks
unlikelyzero opened this issue Mar 29, 2022 · 4 comments
Closed
4 of 14 tasks

[Build] Move off of all unnecessary loaders for webpack 5 #5007

unlikelyzero opened this issue Mar 29, 2022 · 4 comments
Labels
type:maintenance tests, chores, or project maintenance
Milestone

Comments

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Mar 29, 2022

Summary

We upgraded to webpack 5 and now have some dependencies that are no longer necessary.

Let's card up the work necessary to remove all unneeded dependencies and update our webpack config:

Investigate the following loaders: -- This will be done in issue #5013

  • "resolve-url-loader": "4.0.0",
  • "babel-loader": "8.2.3",
  • "css-loader": "4.0.0",
  • "exports-loader": "0.7.0",
  • "imports-loader": "0.8.0",
  • "karma-sourcemap-loader": "0.3.8",
  • "resolve-url-loader": "4.0.0",
  • "sass-loader": "12.4.0",
  • "style-loader": "^1.0.1",

Vue Loader is a problem child:

  • "vue-loader": "15.9.8" To be filed separately
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Mar 29, 2022
@shefalijoshi
Copy link
Contributor

Moving out the investigation to a separate task.

@unlikelyzero
Copy link
Collaborator Author

unlikelyzero commented Apr 4, 2022

Testing Notes

Verify that openmct can be built locally and that the error messages generated during build time make sense

@michaelrogers
Copy link
Contributor

Successfully built Open MCT without errors messages on 2022-04-04.

@khalidadil
Copy link
Contributor

^ same, in testathon on 04/04/2022

@unlikelyzero unlikelyzero added this to the Target:2.0.2 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

No branches or pull requests

5 participants