Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LAD Tables][Display Layout] LAD Table in Display Layout Composition Issues #5033

Closed
4 of 5 tasks
jvigliotta opened this issue Apr 5, 2022 · 6 comments
Closed
4 of 5 tasks

Comments

@jvigliotta
Copy link
Contributor

Summary

Some items added to a lad table in a display layout get lost.

Expected vs Current Behavior

Items should not disappear from a lad table when it's in a display layout.

Steps to Reproduce

  1. Create a Display Layout with a LAD Table in it
  2. While not in edit mode, drag a telemetry point into the LAD table
  3. Now drag and drop another one
  4. This is where the first item is replaced

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available? (just add the deleted item again)
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?

Additional Information

Screen.Recording.2022-04-05.at.11.48.47.AM.mov
@davetsay
Copy link
Contributor

Seems related to couchdb. Installing couchdb and using the couchdb plugin instead of localstorage plugin makes this reproducible locally. Not reproducible locally using localstorage plugin. probably the order of saving composition is making composition out of sync

my repro steps

  1. create display layout
  2. add LAD table
  3. exit save mode
  4. drag and drop telemetry onto LAD table (LAD table must not be selected, inspector should display details for display layout, not LAD table)
  5. expand LAD table in tree and observe telemetry not added but is visible in layout

@akhenry
Copy link
Contributor

akhenry commented Apr 28, 2022

Downgrading from blocker to critical, workaround is to compose LAD table separately.

@davetsay
Copy link
Contributor

Closing as no longer reproducible. Marking unverified for test verification.

@shefalijoshi
Copy link
Contributor

Reproduced on banner testathon with instructions in the bug above.

@ozyx
Copy link
Member

ozyx commented Jun 27, 2022

Testathon 6/27/22:

Verified? Was not able to reproduce the issue using either @jvigliotta's or @davetsay's instructions above.

@charlesh88
Copy link
Contributor

Verified fixed Testathon 07-01-22.
image

@unlikelyzero unlikelyzero added this to Needs triage in Build 6 Blockers via automation Jul 17, 2022
@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation Jul 17, 2022
@unlikelyzero unlikelyzero added this to the Sprint:2.0.7 milestone Jul 17, 2022
@unlikelyzero unlikelyzero moved this from Needs triage to Needs an automated test in Build 6 Blockers Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Build 6 Blockers
Needs an automated test
Development

Successfully merging a pull request may close this issue.

7 participants