Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook types for shift logging #5035

Closed
charlesh88 opened this issue Apr 5, 2022 · 4 comments · Fixed by #5173
Closed

Notebook types for shift logging #5035

charlesh88 opened this issue Apr 5, 2022 · 4 comments · Fixed by #5173

Comments

@charlesh88
Copy link
Contributor

Introduce new Notebook "typing" to allow support for desired shift logging functionality. Details from discussion 4/5/22:

  • New types:
    • Notebook (unrestricted type)
    • Shift Log (restricted type)
  • Pages are locked or unlocked (exact terminology is TBD).
  • Unlocked pages allow same functionality as current purpose Notebook.
  • Locked pages do not allow new entries or editing/deletion of existing entries.
  • A section with at least one locked page cannot be deleted.
  • A Notebook with at least one section with at least one locked page cannot be deleted.
  • Implementation notes:
    • Two different Notebook types in the Create menu, avoids issues with "create-only" properties to prevent Notebook type switching after creation.
    • Per deployment: Notebook types (restricted/unrestricted) can be named (Notebook/Shift Log/etc.).
@unlikelyzero
Copy link
Collaborator

@jvigliotta please run through #5073

@jvigliotta
Copy link
Contributor

Testing

  • make sure regular notebooks work exactly how they used to
  • make sure you can pass in a name to the Notebook and RestrictedNotebook plugins and that they show in Open MCT
  • create a restricted notebook
  • make sure you can do anything that you can do to a normal notebook (observe "Lock Page" shows when an entry is started)
  • open section/page sidebar
  • Lock a page (verify confirmation)
  • make sure locks show for page and the section that page is in
  • make sure you cannot remove the restricted notebook (right click remove from tree)
  • make sure you can't edit section titles or section names if locked
  • try to delete/edit an entry from a locked notebook (you should not be able)
  • try to remove an embed from a locked page entry (make sure you can preview though)
  • make sure if the notebook section/page was default, that it was NOT default once locked
  • try to drop an item into a locked page (you should not be able), do the same with a snapshot
  • make sure search works as expected
  • in search, make sure there are locked and unlocked page entries with embeds, make sure you can remove unlocked ones and not remove locked ones

@rukmini-bose
Copy link
Contributor

Verified Testathon 06/15/2022 (I'm pretty sure)

@unlikelyzero
Copy link
Collaborator

Closing as feature complete. Will file new issues as they come across.

@unlikelyzero unlikelyzero added this to the Target:2.0.5 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants