-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static limit values to LAD tables #5051
Comments
Let's make the limit column show by default IF LIMITS ARE DEFINED for any of the telemetry points. We need to make sure it works with the column show/hide controls in the inspector. |
I've a got first draft here, but could use some design help from @charlesh88 and/or @akhenry: We've got two values (high and low) for each limit that needs to be displayed and creating a string that combines the together. Do we instead want separate columns for high and low? Also I could use some advice about limits in general. As telemetry items could have different classes (e.g., one could have "CRITICAL", and another "HIGH"), I'm currently taking the union of them all for column names. Is this correct? Thanks for the help! |
@unlikelyzero did you mean to unassign this? |
This happened awhile back, but @charlesh88 & @akhenry were good with both the union of limits in the table, and the string combining the high/low values into a string (as LAD tables aren't sortable). |
To test:
|
@scottbell let's sync on testing this as a feature on quickstart
What we wouldn’t want to waste time on are safeguards for making sure the limits make sense. (lower limit greater than upper limit validation) |
Testathon 2024-03-20 limits from a sine wave generator display as expected. |
Is your feature request related to a problem? Please describe.
In the case where static limit values are defined by a limit provider for a given telemetry point, our LAD tables should display those limit values. Currently static limit values are rendered as a limit line in plots, this would bring the same concept to LAD tables.
Describe the solution you'd like
Telemetry limit values should be displayed as additional columns in the LAD table
Additional context
There is a broader desire to bring all of the customizability of telemetry tables to LAD tables. If considered as part of that change, the new limit columns could be optionally shown or hidden by the user.
The text was updated successfully, but these errors were encountered: