Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement minimal "fault management" capability #5052

Closed
akhenry opened this issue Apr 11, 2022 · 13 comments · Fixed by #5212 or #5479
Closed

Implement minimal "fault management" capability #5052

akhenry opened this issue Apr 11, 2022 · 13 comments · Fixed by #5212 or #5479

Comments

@akhenry
Copy link
Contributor

akhenry commented Apr 11, 2022

Is your feature request related to a problem? Please describe.
A basic "fault management" capability that summarizes the current state of alarms across all subsystems.

Describe the solution you'd like
Add a dedicated alarm summary screen to Open MCT.

Describe alternatives you've considered
If exposed as telemetry points, alarms can be listed in telemetry tables. This solution shows both current and historical alarms, which generates a lot of visual noise.

@rukmini-bose
Copy link
Contributor

rukmini-bose commented Jun 7, 2022

TESTING INSTRUCTIONS

  1. Select Fault Management object from the Object Tree.
  2. Ensure that every fault contains a criticality icon.
  3. Make sure selection of one fault does the following: (a) Selected fault is highlighted blue to indicate it being selected. (b) Inspector will display the appropriate fault details for that fault.
  4. Make sure that selecting multiple faults eliminates the fault details from inspector.
  5. Ensure that the disposition button for an individual fault works by selecting acknowledge or shelve. Then, navigate to each view and ensure that the correct faults appear in the correct disposition views. Also, check the same with selecting multiple faults and using the larger disposition options located directly under search.
  6. Ensure that search works properly by entering keywords and observing the correct faults are shown.
  7. Check to see if the sort button works and changes according to the options selected (Newest First, Oldest First, Severity)
  8. When selecting the Acknowledged view, ensure that the criticality icons are not blinking. and that the criticality icon includes a checkmark.
  9. When selecting the Unacknowledged view, check that the criticality icons are blinking.
  10. When selecting the Shelved view, check that the contents of the fault are italicized and _slightly greyed out, and criticality icon is not blinking.
  11. When selecting Standard View, ensure that only acknowledged and unacknowledged faults appear, and its criticality icons are blinking accordingly.
  12. Shelve a fault for a short period of time. When the time specified runs out, ensure that the fault returns back to its Unacknowledged state and is NOT shelved.

Main view with selected fault

Screen Shot 2022-07-05 at 3 50 31 PM

Disposition dialog

Screen Shot 2022-07-05 at 3 50 38 PM

Acknowledged fault

Screen Shot 2022-07-05 at 4 20 11 PM

Width < 600px in a layout

Screen Shot 2022-07-05 at 4 19 26 PM

@jvigliotta
Copy link
Contributor

Can't currently Acknowledge or Shelve a fault.

@jvigliotta
Copy link
Contributor

Seeing this error when "Shelving" a Fault. (not my fault)
Screen Shot 2022-06-15 at 2 56 24 PM
Screen Shot 2022-06-15 at 2 57 28 PM

@rukmini-bose
Copy link
Contributor

rukmini-bose commented Jun 15, 2022

(1) Cannot currently acknowledge/ shelve faults without getting the error message that Jamie gets.

(2) When opening up the details in the inspector, the "Live Value" is not updating in the similar fashion as it is in the main dashboard. It is only capturing the values that were taken at the time of selecting the fault.
Screen Shot 2022-06-15 at 3 23 54 PM

@unlikelyzero
Copy link
Collaborator

Still waiting for @unlikelyzero to close out once we get yamcs role permissions

@unlikelyzero unlikelyzero self-assigned this Jun 29, 2022
@charlesh88
Copy link
Contributor

charlesh88 commented Jul 8, 2022

Testathon 07-08-22: verified NOT FIXED

  • Shelved alarms still appear in the Unacknowledged list view and display the blinking cursor, but shouldn't do either.

Screen Shot 2022-07-08 at 11 26 21 AM

- Only one fault available, can't verify sorting.

@charlesh88 charlesh88 self-assigned this Jul 8, 2022
@jvigliotta
Copy link
Contributor

If we don't have the role to manage faults, should we hide fault management or possibly show a notification when someone unsuccessfully tries to ack or shelve?

@davetsay
Copy link
Contributor

davetsay commented Jul 8, 2022

partially verified the below. unable to verify other steps due to lack of role

  • Select Fault Management object from the Object Tree.
  • Ensure that every fault contains a criticality icon.
  • Make sure selection of one fault does the following: (a) Selected fault is highlighted blue to indicate it being selected. (b) Inspector will display the appropriate fault details for that fault.
  • Make sure that selecting multiple faults eliminates the fault details from inspector.
  • Ensure that search works properly by entering keywords and observing the correct faults are shown.
  • When selecting the Unacknowledged view, check that the criticality icons are blinking.

@akhenry
Copy link
Contributor Author

akhenry commented Jul 8, 2022

To enable shelving and acknowledging of alarms:

  1. Create an ssh tunnel to the test environment. ie.
    ssh -L 8090:localhost:8090 <yamcs hostname>
  2. Click on the admin menu at the top of the screen
  3. Navigate to Access Control > Users
  4. Click on your user
  5. Apply the Ground Control (gc) role.
  6. Save Changes
  7. Refresh Open MCT and you should be able to acknowledge and shelve faults.

@akhenry
Copy link
Contributor Author

akhenry commented Jul 10, 2022

@charlesh88 The issue here is that "shelved" and "acknowledged" are orthogonal states in the data design. The data design allows a fault to be either shelved and acknowledged, or shelved and unacknowledged. A shelved alarm does not get acknowledged when it is shelved. I have tweaked our UI so that it matches the behavior in Yamcs, but be aware that this is now incorrectly reflecting the state of the alarms.

I think this is ok because I think it matches user expectations, even if the pedantic logician in me is grumbling about it.

@akhenry
Copy link
Contributor Author

akhenry commented Jul 10, 2022

Testing instructions

  1. From the "standard" view, shelve an alarm
  2. Confirm that the shelved alarm now only appears in the "shelved" view, and does not appear in the the "Acknowledged" or "Unacknowledged" views.
  3. Unshelve the alarm and confirm that it returns to the "Standard View", and the "Unacknowledged" view.
  4. Acknowledge the alarm
  5. Confirm that it appears in the "Acknowledged" View, and not the "Unacknowledged" or "Shelved" views.

@akhenry akhenry mentioned this issue Jul 10, 2022
15 tasks
@akhenry akhenry closed this as completed Jul 11, 2022
@charlesh88
Copy link
Contributor

charlesh88 commented Jul 11, 2022

Testathon 07-11-22 verified fixed. Filed #5481 for console errors being thrown.

@davetsay
Copy link
Contributor

Verified (except could not test filters/sort on multiple alarms)

@unlikelyzero unlikelyzero added needs:e2e Needs an e2e test and removed unverified labels Jul 11, 2022
@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation Jul 18, 2022
@unlikelyzero unlikelyzero added this to the Target:2.0.5 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

6 participants