Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plot] Unit column is not populating in plot legend #5058

Closed
4 of 5 tasks
davetsay opened this issue Apr 12, 2022 · 3 comments · Fixed by #5062
Closed
4 of 5 tasks

[Plot] Unit column is not populating in plot legend #5058

davetsay opened this issue Apr 12, 2022 · 3 comments · Fixed by #5062
Labels
bug:regression It used to work. Now it doesn't :( help_wanted Help the Open MCT project! needs:e2e Needs an e2e test severity:critical type:bug

Comments

@davetsay
Copy link
Contributor

Summary

The unit column cells are blank in the plot legends

Expected vs Current Behavior

Unit column should display the unit type in the plot legend

Steps to Reproduce

  1. Go to a plot view containing telemetry
  2. expand the plot legend
  3. hover over the points in the plot
  4. Observe that on hover, the point data is populated in the plot legend, but the units are not

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?

Additional Information

@davetsay davetsay added type:bug bug:regression It used to work. Now it doesn't :( labels Apr 12, 2022
@shefalijoshi
Copy link
Contributor

Currently the unit is only being set when the plot initializes (defaultModel). The unit must also be set if there are changes to the yKey after initialization.

@akhenry
Copy link
Contributor

akhenry commented Apr 25, 2022

Verified that the original issue is fixed (units are showing up).

Also noticed the issue that @shefalijoshi mentioned with changing the y-axis value. We need a followup issue for this.

@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation May 10, 2022
@unlikelyzero unlikelyzero added the help_wanted Help the Open MCT project! label May 10, 2022
@unlikelyzero unlikelyzero moved this from To triage to Ready! in Improve Test Coverage Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( help_wanted Help the Open MCT project! needs:e2e Needs an e2e test severity:critical type:bug
Projects
Development

Successfully merging a pull request may close this issue.

5 participants
@davetsay @akhenry @shefalijoshi @unlikelyzero and others