Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible layouts do not save changes when switched into "rows" mode #5084

Closed
2 of 5 tasks
akhenry opened this issue Apr 18, 2022 · 4 comments
Closed
2 of 5 tasks

Flexible layouts do not save changes when switched into "rows" mode #5084

akhenry opened this issue Apr 18, 2022 · 4 comments

Comments

@akhenry
Copy link
Contributor

akhenry commented Apr 18, 2022

Summary

A newly created flexible layout will lose all changes on save and revert to an empty layout if the layout is created in "rows" mode. Columns mode seems to work ok.

Expected vs Current Behavior

Flexible layouts should retain all changes on save.

Steps to Reproduce

  1. Create a new flexible layout
  2. Click on the button to switch the orientation to "rows"
    Screen Shot 2022-04-18 at 3 35 22 PM
  3. Drag two objects into the layout. I used two different sinewave generators, but I don't think it matters what you use.
  4. Click "Save and Finish Editing"
  5. Observe that the layout is now empty.

Environment

  • Open MCT Version: 0a40c8d
  • Deployment Type: local

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
@unlikelyzero unlikelyzero added this to Needs triage in Bug Tracker via automation Apr 19, 2022
@khalidadil
Copy link
Contributor

Verified in Testathon on 04/21/22

@akhenry
Copy link
Contributor Author

akhenry commented Apr 21, 2022

This might be a specific manifestation of #5097

@davetsay
Copy link
Contributor

davetsay commented Apr 27, 2022

Lol. I did not see you linked this issue. This is absolutely a specific manifestation of #5097 . Its not the row/column orientation. Its the modifying of the object in which you are modifying composition. Interestingly enough, composition changes before the toggling of row/column mode will be persisted. After that modification, we seem to be using a stale model and so changes are not persisted.

Closing and updating description of other ticket.

Bug Tracker automation moved this from Needs triage to Done Apr 27, 2022
@davetsay davetsay added the invalid duplicate or incorrectly filed label Apr 27, 2022
@davetsay davetsay reopened this Apr 28, 2022
Bug Tracker automation moved this from Done to Needs triage Apr 28, 2022
@davetsay davetsay removed the invalid duplicate or incorrectly filed label Apr 28, 2022
Bug Tracker automation moved this from Needs triage to Done May 2, 2022
@unlikelyzero unlikelyzero added Target:2.0.3 needs:e2e Needs an e2e test labels May 2, 2022
@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation May 2, 2022
@akhenry
Copy link
Contributor Author

akhenry commented May 2, 2022

Verified fixed!

@unlikelyzero unlikelyzero added the help_wanted Help the Open MCT project! label May 10, 2022
@unlikelyzero unlikelyzero removed this from To triage in Improve Test Coverage May 10, 2022
@unlikelyzero unlikelyzero removed help_wanted Help the Open MCT project! needs:e2e Needs an e2e test labels May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants