Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend color is not in sync with plot color on change #5233

Closed
3 of 6 tasks
shefalijoshi opened this issue May 20, 2022 · 11 comments · Fixed by #5371
Closed
3 of 6 tasks

Legend color is not in sync with plot color on change #5233

shefalijoshi opened this issue May 20, 2022 · 11 comments · Fixed by #5371
Labels
bug:visual Visual problem. Not a functional issue needs:e2e Needs an e2e test severity:medium type:bug
Milestone

Comments

@shefalijoshi
Copy link
Contributor

shefalijoshi commented May 20, 2022

Summary

Legend needs to update swatch color when user sets color from Plot Series area in Inspector.

Expected vs Current Behavior

User currently must nav away and back to see the change, which is undesirable.

Steps to Reproduce

  1. Create an overlay plot
  2. Add a telemetry endpoint to it
  3. Change the color of the series from inspector properties
  4. Observe that the plot series color changes, but the legend shows the old color in the swatch.

Environment

  • Open MCT Version: 2.0.3
  • Deployment Type: all
  • OS: Mac / Windows
  • Browser: All

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?

Additional Information

In the image below, the swatch colors don't match the plot colors.

image

@akhenry
Copy link
Contributor

akhenry commented Jun 7, 2022

It's a bug, it doesn't need to block feature freeze.

@unlikelyzero unlikelyzero added the bug:visual Visual problem. Not a functional issue label Jun 14, 2022
@alizenguyen alizenguyen linked a pull request Jun 18, 2022 that will close this issue
15 tasks
@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation Jul 17, 2022
@unlikelyzero unlikelyzero added this to Needs triage in Build 6 Blockers via automation Jul 17, 2022
@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Jul 17, 2022
@unlikelyzero unlikelyzero added this to the Sprint:2.0.7 milestone Jul 17, 2022
@unlikelyzero unlikelyzero moved this from To triage to In progress in Improve Test Coverage Jul 17, 2022
@unlikelyzero unlikelyzero moved this from Needs triage to e2e Test Added in Build 6 Blockers Jul 17, 2022
@unlikelyzero unlikelyzero moved this from In progress to Integrated in Improve Test Coverage Sep 13, 2022
@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 09/30/22

@ozyx
Copy link
Member

ozyx commented Sep 30, 2022

Not fixed. Testathon 09/30/22

  • While still in edit mode after creating overlay plot and dragging on a telemetry object, changed plot series color and it did not update the color in the legend.
  • However, clicking "Save" and going back into edit mode did update the swatch.
  • Plot series color changed on click as expected.

@khalidadil
Copy link
Contributor

@ozyx I seem to be able to change colors on telemetry immediately after dragging it into a overlay plot

@ozyx
Copy link
Member

ozyx commented Sep 30, 2022

@ozyx I seem to be able to change colors on telemetry immediately after dragging it into a overlay plot

The color of the plot did change color, but the color of the swatch did not until I saved / hit edit again. Not sure if this was intended to be fixed in this PR, but it feels weird with my end-user hat on.

@khalidadil
Copy link
Contributor

@ozyx ah, I get what you're saying! I see that too. That's a good observation

@unlikelyzero unlikelyzero reopened this Sep 30, 2022
Improve Test Coverage automation moved this from Integrated to In progress Sep 30, 2022
Build 6 Blockers automation moved this from e2e Test Added to Needs triage Sep 30, 2022
@akhenry akhenry modified the milestones: Target:2.1.1, Target:2.1.2 Oct 6, 2022
@akhenry akhenry removed the unverified label Oct 6, 2022
@shefalijoshi shefalijoshi modified the milestones: Target:2.1.2, 2.1.3 Nov 1, 2022
@unlikelyzero
Copy link
Collaborator

Build 6 Blocker which was left over

@charlesh88
Copy link
Contributor

charlesh88 commented Jan 24, 2023

Verified NOT fixed Testathon 2023-01-24 - sporadically, the legend would not update, but at other times would. See related issue #6176.

@michaelrogers
Copy link
Contributor

When testing during testathon 2023-01-24 I was able to successfully change the chart color but the legend was not in sync. So issue does not appear to be fixed.

@jvigliotta
Copy link
Contributor

What they said...

@charlesh88
Copy link
Contributor

Verified fixed Testathon 2023-01-31. Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment