Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fault Management] Icon not showing in fault list due to case issue with class #5299

Closed
1 of 7 tasks
jvigliotta opened this issue Jun 7, 2022 · 4 comments · Fixed by #5298
Closed
1 of 7 tasks

[Fault Management] Icon not showing in fault list due to case issue with class #5299

jvigliotta opened this issue Jun 7, 2022 · 4 comments · Fixed by #5298

Comments

@jvigliotta
Copy link
Contributor

Summary

Icons weren't showing during initial test. Class case was the issue.

Expected vs Current Behavior

Icons should show.

Steps to Reproduce

  1. View faults.
  2. Icons no show.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@jvigliotta
Copy link
Contributor Author

Testing

  • make sure icons show in fault list

@scottbell
Copy link
Contributor

scottbell commented Jun 8, 2022

To test, enable plugin in index.html:
openmct.install(openmct.plugins.example.ExampleFaultSource());
and add in the console:

const faults = {
   "alarms": [
     {
       "type": "PARAMETER",
       "fault": {
         "acknowledged": false,
         "currentValueInfo": {},
         "id": "id-/ViperGround/Test-1-navcamPanAngle",
         "name": "navcamPanAngle",
         "namespace": "/ViperGround/Test-1",
         "seqNum": 0,
         "severity": "WATCH",
         "shelved": true,
         "shortDescription": "Camera gimble angle with alarm definitions",
         "triggerTime": "2022-04-25T21:33:05.806Z",
         "triggerValueInfo": {
           "value": 1.5935132503509521,
           "rangeCondition": "HIGH",
           "monitoringResult": "WARNING"
         }
       }
     },
     {
       "type": 1,
       "fault": {
         "acknowledged": false,
         "currentValueInfo": {},
         "id": "id-/ViperGround/Test-2-navcamPanAngle",
         "name": "navcamPanAngle",
         "namespace": "/ViperGround/Test-2",
         "seqNum": 0,
         "severity": "WARNING",
         "shelved": false,
         "shortDescription": "Camera gimble angle with alarm definitions",
         "triggerTime": "2022-04-26T21:33:05.806Z",
         "triggerValueInfo": {
           "value": 1.29,
           "rangeCondition": "HIGH",
           "monitoringResult": "WARNING"
         }
       }
     },
     {
       "type": 2,
       "fault": {
         "acknowledged": false,
         "currentValueInfo": {},
         "id": "id-/ViperGround/Test-3-navcamPanAngle",
         "name": "navcamPanAngle",
         "namespace": "/ViperGround/Test-3",
         "seqNum": 0,
         "severity": "CRITICAL",
         "shelved": false,
         "shortDescription": "Camera gimble angle with alarm definitions",
         "triggerTime": "2022-04-27T21:33:05.806Z",
         "triggerValueInfo": {
           "value": 2.19,
           "rangeCondition": "LOW",
           "monitoringResult": "CRITICAL"
         }
       }
     }
   ]
};
localStorage.setItem('faults', JSON.stringify(faults));

@charlesh88
Copy link
Contributor

Testathon 07-08-22: verified fixed.

@davetsay
Copy link
Contributor

davetsay commented Jul 8, 2022

verified

@akhenry akhenry removed the unverified label Jul 8, 2022
@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation Jul 17, 2022
@unlikelyzero unlikelyzero added this to Needs triage in Build 6 Blockers via automation Jul 17, 2022
@unlikelyzero unlikelyzero added this to the Sprint:2.0.7 milestone Jul 17, 2022
@unlikelyzero unlikelyzero moved this from Needs triage to Needs an automated test in Build 6 Blockers Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Build 6 Blockers
Needs an automated test
Development

Successfully merging a pull request may close this issue.

6 participants