Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit tests] Update unit tests to match new describe() and it() syntax checks #5405

Closed
2 tasks
unlikelyzero opened this issue Jun 28, 2022 · 1 comment · Fixed by #5503
Closed
2 tasks

[Unit tests] Update unit tests to match new describe() and it() syntax checks #5405

unlikelyzero opened this issue Jun 28, 2022 · 1 comment · Fixed by #5503
Labels
type:maintenance tests, chores, or project maintenance

Comments

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Jun 28, 2022

Summary

karma-jasmine-5.1.0 updated syntax checks after giving us deprecation warnings for months. The following tests are failing

Chrome Headless 103.0.5060.53 (Linux x86_64) ERROR
  An error was thrown in afterAll
  Error: describe with no children (describe() or it()): the plugin when invoked
      at <Jasmine>
      at /tmp/_karma_webpack_276262/commons.js:929829:5
      at <Jasmine>
      at ./src/plugins/viewDatumAction/pluginSpec.js (/tmp/_karma_webpack_276262/commons.js:929777:1)
      at __webpack_require__ (/tmp/_karma_webpack_276262/runtime.js:23:42)
      at webpackContext (/tmp/_karma_webpack_276262/commons.js:931150:9)
      at Array.forEach (<anonymous>)
Chrome Headless 103.0.5060.53 (Linux x86_64) ERROR
  An error was thrown in afterAll
  Error: describe with no children (describe() or it()): the plugin when invoked
      at <Jasmine>
      at /tmp/_karma_webpack_276262/commons.js:929829:5
      at <Jasmine>
      at ./src/plugins/viewDatumAction/pluginSpec.js (/tmp/_karma_webpack_276262/commons.js:929777:1)
      at __webpack_require__ (/tmp/_karma_webpack_276262/runtime.js:23:42)
      at webpackContext (/tmp/_karma_webpack_276262/commons.js:931150:9)
      at Array.forEach (<anonymous>)

Update:

  • Fix all failing tests associated with the new check
  • Update karma-jasmine-5.1.0 dependency
@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 08/02/22 - All unit tests pass when running npm run test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants