Search should indicate if the result is from a removed object

[ozyx]

The object and tag search can bring up results from objects which have been removed. This is fine, but there is currently no visual indication of this. This can potentially lead to some confusing search results.

This is most apparent with tags:

...but can also be confusing with objects:

Especially if they have the same name:

[charlesh88]

This is a good candidate as we move forward on the search capability. By default, we should not include removed objects in the results, with an option in an Advanced search UI to enable searching for removed objects. Result items should also include a designator when an object has been removed. If we do this, removed objects should also be allowed to be restored via a UI gesture.

In the short-term, I'd argue we should not include removed objects at all in order to avoid confusion as noted, but I'm open to arguments to the contrary.

[scottbell]

This is a good candidate as we move forward on the search capability. By default, we should not include removed objects in the results, with an option in an Advanced search UI to enable searching for removed objects. Result items should also include a designator when an object has been removed. If we do this, removed objects should also be allowed to be restored via a UI gesture.

In the short-term, I'd argue we should not include removed objects at all in order to avoid confusion as noted, but I'm open to arguments to the contrary.

Agree regarding removed items in search, but we'll need a good way to designate them "deleted". We used to rely on them no longer being reachable in the network graph, but this doesn't work for annotations. One idea to do this:
Have objects that are deleted (like annotations) designated with a deleted boolean attribute. When deleted is present and true, don't index the item.

[scottbell]

@akhenry Thinking about this more, another idea is index all the regular domain objects first (i.e., non-annotations), and then index all the annotations. We could then only index annotations that have "reachable" targets, namely annotations that have an indexed domain object target.

[jvigliotta]

This is related, but possibly moot if we don't show the objects in search. Although, if you know the id, you could still navigate to it. #5603

Seems like there's a bigger issue of just what to do with items that have been removed.

[scottbell]

Orphaned objects should not be returned anymore in search

[khalidadil]

I'm still seeing objects that are missing in the tree. I think @jvigliotta did some digging on this.

Edit: It looks like this issue is specific to our banner setup and how we lost/restored some data.

[khalidadil]

When I create an object and then delete it, it no longer shows up in the search. There may be some other search issues, but this seems to be fixed. Verified Fixed in Testathon on 08/04/22