Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Add visual testing suite to circle CI checks #5478

Closed
5 tasks done
unlikelyzero opened this issue Jul 10, 2022 · 2 comments · Fixed by #5570
Closed
5 tasks done

[Build] Add visual testing suite to circle CI checks #5478

unlikelyzero opened this issue Jul 10, 2022 · 2 comments · Fixed by #5570
Labels
needs:e2e Needs an e2e test type:maintenance tests, chores, or project maintenance
Projects
Improve Test Coverage

Comments

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Jul 10, 2022 •
edited

Summary

The visual tests have become stable enough to run against each PR. We got an upgraded visual plan with more snapshots. We should make their execution automatic instead of ad-hoc to catch these issues:
#5467

  • Fix any flakiness associated with timestamps
  • Update CircleCI config to include a visual run
  • Test this against an artificial regression on master
  • Trigger baseline to run every merge to master
  • Disable Github Action
@unlikelyzero unlikelyzero added type:maintenance tests, chores, or project maintenance Target:2.1.0 labels Jul 10, 2022
@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation Jul 10, 2022
@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Jul 10, 2022
@unlikelyzero unlikelyzero moved this from To triage to Ready! in Improve Test Coverage Jul 10, 2022
@unlikelyzero unlikelyzero mentioned this issue Jul 27, 2022
Merged
15 tasks
@unlikelyzero
Copy link
Collaborator Author

Testing Instructions

  • Create a PR against master and verify that circle CI runs the visual tests
  • Verify that the Visual tests run in CircleCI trigger a Percy result

@khalidadil
Copy link
Contributor

I've created a PR today that triggered the Percy result. Verified Fixed in Testathon on 08/04/22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs:e2e Needs an e2e test type:maintenance tests, chores, or project maintenance
Projects
Improve Test Coverage
Ready!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Visual Test for Snow Theme and add visual tests to PR execution nasa/openmct
2 participants
@khalidadil @unlikelyzero