Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open MCT is swallowing some persistence errors #5488

Closed
1 of 7 tasks
akhenry opened this issue Jul 12, 2022 · 3 comments · Fixed by #5576
Closed
1 of 7 tasks

Open MCT is swallowing some persistence errors #5488

akhenry opened this issue Jul 12, 2022 · 3 comments · Fixed by #5576
Labels
bug:regression It used to work. Now it doesn't :( severity:critical type:bug
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Jul 12, 2022

Summary

In the event of a persistence conflict an error is shown in the JavaScript console, but is not displayed in the UI to the user.

Expected vs Current Behavior

The user should be informed of any persistence errors as this may impact their workflows.

Steps to Reproduce

The only way that I've found of consistently triggering a persistence conflict is by repeatedly renaming an object. They also happen sporadically in other cases. Note that this has highlighted another regression.

  1. Rename an object
  2. Renamed it again
  3. Open the JavaScript console and observe that a persistence conflict has occurred, but none has been displayed to the user.

Environment

  • Open MCT Version: 1c8784f
  • Deployment Type: VIPER Testathon

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@khalidadil
Copy link
Contributor

I saw a few forms of this during testathon on 07/12/22. I would edit the properties on a hyperlink or a web page object in a subfolder, and the display would reflect the properties for a few seconds, but would then revert to the old settings. @ozyx noticed multiple PUT calls being made, including a PUT call with the old properties.

Here are some examples:

Screen.Recording.2022-07-12.at.4.50.35.PM.mov
Screen.Recording.2022-07-12.at.5.08.24.PM.mov

@ozyx
Copy link
Member

ozyx commented Jul 13, 2022

@khalidadil see also #5398 , I believe this is the same issue. And unless anyone has experienced this with localStorage, I also believe this bug is specific to CouchDB persistence?

@unlikelyzero unlikelyzero added this to the Sprint:2.0.7 milestone Jul 17, 2022
@akhenry akhenry mentioned this issue Jul 29, 2022
15 tasks
@akhenry
Copy link
Contributor Author

akhenry commented Jul 29, 2022

Test Instructions

  1. Execute the reproduction steps in the issue description
  2. Verify that a notification now appears informing the user that a persistence error has occurred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( severity:critical type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants