Fix code scanning alert - Incomplete string escaping or encoding

[unlikelyzero]

Tracking issue for:

• https://github.com/nasa/openmct/security/code-scanning/2

[akhenry]

I believe that this has been incorrectly identified as a security risk. The string in question is not a user input, it's machine generated.

[unlikelyzero]

@alizenguyen can you verify if this appears in your CodeQL/LGTM research?

[akhenry]

I believe this is a false positive. We are not trying to do general character escaping here. What this code is doing is adding an escape character specifically to : characters in namespaces. This is because : has a special meaning in Open MCT keystrings, and delineates namespaces from keys. There is some corresponding code in parseKeyString that subsequently removes this escape character.

Moreover, the highlighted code is not a user input, and as such presents no security vulnerability.

[akhenry]

Dismissed corresponding alert for reasons above.