Infinite loop in some search cases

[akhenry]

Summary

Typing certain text into the search box can result in infinite requests in the network tab.
Looks like it's something to do with getOriginalPath. Suspect there is a circular reference somewhere.

Steps to Reproduce

1. Search for "orphan"
2. Observe that the search activity indicator appears and never disappears.
3. Observe that no results are shown
4. Open the network tab and observe that requests are firing off endlessly.

Environment

• Open MCT Version: 2.0.7
• Deployment Type: testathon

Impact Check List

• Data loss or misrepresented data?
• Regression? Did this used to work or has it always been broken?
• Is there a workaround available?
• Does this impact a critical component?
• Is this just a visual bug with no functional impact?
• Does this block the execution of e2e tests?
• Does this have an impact on Performance?

Additional Information

[akhenry]

Critical because it leaves the application in a not so great state

[scottbell]

How do you create a circular reference? Links would be one way, but we're not indexing them.

I've created a folder whose parent is itself. I'll use that as a test case for the interim as it appears to cause an infinite loop in search.

[scottbell]

@akhenry would something like this work?
https://github.com/nasa/openmct/pull/5619/files

We basically just check to see if we've walked this parent before to avoid cycles.

It seems to work when a folder has itself for a parent, and when a folder has a child as its parent, e.g. Sub Folder A was manually changed to have Sub Folder C as its parent, though its composition lists its parent as First Folder :

The disadvantage of this is that per the originalPath, Sub Folder A is no longer reachable (no link to root), and thus won't appear in search results.

[akhenry]

@scottbell Did some more investigation and found the culprit. I think the issue is in the MoveAction. It allows an object to be moved to its own child.

I like your proposed approach, and I will file a separate issue to fix the move and link actions to prevent circular references from being created.

[akhenry]

Created #5620 to address the issue in the actions themselves.

[unlikelyzero]

@ozyx to test

[ozyx]

Verified 8/22/22 Testathon:

Using CouchDB locally, created a folder whose parent was itself. Searched for the folder name and it showed up correctly in the search results without infinite search loop or unending network requests.

Only other issue was a duplicate entry, documented here: #5690