Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Condition Sets] Cannot add Condition to Condition Set #5625

Closed
3 of 7 tasks
charlesh88 opened this issue Aug 7, 2022 · 3 comments · Fixed by #5636
Closed
3 of 7 tasks

[Condition Sets] Cannot add Condition to Condition Set #5625

charlesh88 opened this issue Aug 7, 2022 · 3 comments · Fixed by #5636

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Aug 7, 2022

Summary

Attempting to add a Condition to a new or pre-existing Condition Set doesn't add the Condition in the editor, and throws this console error:

image

Saving and refreshing will display the added Condition, but the Condition Set will not evaluate values and render output. This effects a key component and also results in loss of data, so setting as a blocker.

Expected vs Current Behavior

The Condition should have been added without any console errors and breaking the Condition Set.

Steps to Reproduce

  1. Create a new Condition Set.
  2. Display dev tools.
  3. Click the Add Condition button. No other action (such as adding a data source) needs to be done to cause the issue.
    Observe: no Condition is added, and a console error as shown above occurs.

Environment

  • Open MCT Version: R2.0.7
  • Deployment Type: /stable
  • OS: MacOS
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@charlesh88
Copy link
Contributor Author

8-8-22 3:17 PM: This problem appears to be isolated to 2.0.7.

  • I can replicate this easily on /stable and /testathon in the 2.0.7 build.
  • I can replicate this easily locally by building the release/2.0.7 branch.
  • This problem does NOT happen running latest master locally with 2.1.0.

@unlikelyzero
Copy link
Collaborator

Retesting on 2.0.8 after backmerge

@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon: 8/22

No issues adding new conditions.

@unlikelyzero unlikelyzero added needs:e2e Needs an e2e test and removed unverified labels Aug 22, 2022
@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation Aug 23, 2022
@unlikelyzero unlikelyzero added this to the Target:2.0.8 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
6 participants