Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Conductor History does not work in real-time mode #5626

Closed
2 of 7 tasks
akhenry opened this issue Aug 8, 2022 · 5 comments
Closed
2 of 7 tasks

Time Conductor History does not work in real-time mode #5626

akhenry opened this issue Aug 8, 2022 · 5 comments

Comments

@akhenry
Copy link
Contributor

akhenry commented Aug 8, 2022

Summary

I am observing two issues here. The first is the presence of duplicates entries in the time conductor history, which should not appear. The second is that clicking on an historical entry in real-time mode does nothing, the conductor remains in real-time mode with the same offsets.

Expected vs Current Behavior

Expected behavior needs clarification with @charlesh88

Steps to Reproduce

  1. Load Open MCT
  2. In the Time Conductor, switch to real-time mode
  3. Click the history button to expand the popup
  4. Note that the popup contains duplicate entries
  5. Click on history entries
  6. Observe that nothing happens in the time conductor

Environment

  • Open MCT Version: 2.0.7
  • Deployment Type: Dev

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?
@jvigliotta
Copy link
Contributor

Yeah, there's a lot going on here. There should only be offsets in realtime mode history menu. When click on that it should set those offsets and keep you in realtime mode. Same deal for fixed time, only fixed time bounds should be present in the history menu and they should set the bounds for fixed time mode.

@jvigliotta
Copy link
Contributor

Testing

  • use the time conductor to change times in both fixed and realtime mode
  • open the time conductor history, verify there are no duplicates (can also verify there are no duplicate keys errors in console)
  • verify you can click on a previous timeframe (historical and realtime) and it will set the bounds/offsets appropriately

@charlesh88
Copy link
Contributor

Verified fixed Testathon 8/23/22.

@rukmini-bose
Copy link
Contributor

Verified Testathon 8/23/22

@ozyx
Copy link
Member

ozyx commented Aug 23, 2022

Verified 8/23/22

@unlikelyzero unlikelyzero added this to the Target:2.0.8 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants