Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots should handle Infinity gracefully #5657

Closed
2 of 7 tasks
akhenry opened this issue Aug 12, 2022 · 4 comments · Fixed by #5907
Closed
2 of 7 tasks

Plots should handle Infinity gracefully #5657

akhenry opened this issue Aug 12, 2022 · 4 comments · Fixed by #5907

Comments

@akhenry
Copy link
Contributor

akhenry commented Aug 12, 2022

Summary

Plots will currently fail to render a trace completely if it includes any infinite values. Infinite values can sometimes occur in telemetry where a calculation involves division by zero.

Expected vs Current Behavior

The easiest thing to do for now is probably treat it in the same way we do NaN - that is, don't plot it and instead show a data gap.

Steps to Reproduce

  1. Create a Sine Wave Generator object
  2. View the Sine Wave Generator in a plot
  3. Modify the Sine Wave Generator object to randomly return Infinity
  4. Observe that no data is returned at all. Compare this to the case where NaN is returned and observe that the plot will render the real numbers, with gaps for the NaNs

Environment

  • Open MCT Version: 2.0.8
  • Deployment Type: local dev

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@akhenry akhenry changed the title Plots should handle Infinty gracefully Plots should handle Infinity gracefully Aug 15, 2022
@akhenry
Copy link
Contributor Author

akhenry commented Aug 23, 2022

Downgrading to critical as this shouldn't block the 2.0.8 release.

@michaelrogers
Copy link
Contributor

Fix verified during testathon 12/28/2022 locally against release/2.1.5. Plots handle infinity values without affecting the Y axis autoscaling.

@unlikelyzero
Copy link
Collaborator

@unlikelyzero to find the original telemetry value from yamcs

@unlikelyzero unlikelyzero removed their assignment Dec 28, 2022
@unlikelyzero
Copy link
Collaborator

Couldn't find one. Closing as this may only be reproduced in theoretical circumstances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants