Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook Embeds Should Include New Action Menu #5810

Closed
rukmini-bose opened this issue Sep 27, 2022 · 3 comments · Fixed by #5809
Closed

Notebook Embeds Should Include New Action Menu #5810

rukmini-bose opened this issue Sep 27, 2022 · 3 comments · Fixed by #5809
Labels
type:feature Feature. Required intentional design
Milestone

Comments

@rukmini-bose
Copy link
Contributor

rukmini-bose commented Sep 27, 2022

Is your feature request related to a problem? Please describe.
Notebook embeds need to be enhanced so that users have a more clear action button. At the moment, it is very confusing for a user when interacting with an embed. Clicking parts of the embed may navigate a user away from a Notebook, or do actions that were not intended by a user.

Describe the solution you'd like
We want to implement an enhanced action menu whose action options are more clear to a user. This action menu will be similar in design to our Create menu button, in which, on hover, a description of each option will be displayed to the right side of the menu.

Testing Instructions

  1. Create a notebook entry and drag an embed into it, or navigate to a Notebook object that already contains embeds.
  2. Observe that each embed now contains a 3-dot menu with the following actions: Quick View, Navigate to Item, Navigate to Item In Time, and Remove This Embed.
  3. Select each actions and verify that the following behaviors occur:
    (a) Quick View: Opens a full screen overlay of the embed.
    (b) Navigate to Item in Time: Navigates to item in its time frame when captured.
    (c) Navigate to Item: Navigates to item with the current time settings.
    (d) Remove This Embed: Removes embed from the notebook entry.
  4. Add a snapshot to a notebook entry. Verify that the action menu has the same actions as described above, as well as an additional option called "View Snapshot". Verify that selecting this action will open up the snapshot overlay.
  5. Create a notebook entry that has enough embeds that they cannot fit on one line. Verify that after the embeds are unable to fit on one line, a scrolling container appears to encapsulate all of the embeds.

Additional context
Closes #5809

@unlikelyzero unlikelyzero added this to the Target:2.1.6 milestone Jan 17, 2023
@unlikelyzero unlikelyzero added type:feature Feature. Required intentional design and removed type:enhancement labels Jan 24, 2023
@charlesh88
Copy link
Contributor

Verified fixed Testathon 2023-01-24. Great work!

@davetsay
Copy link
Contributor

verified. really cool.

i am seeing this though
image

@unlikelyzero
Copy link
Collaborator

@davetsay filing as #6217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature. Required intentional design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants