Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Restricted Notebook] Sync changes #5818

Closed
jvigliotta opened this issue Sep 30, 2022 · 2 comments · Fixed by #5741 or #5827
Closed

[Restricted Notebook] Sync changes #5818

jvigliotta opened this issue Sep 30, 2022 · 2 comments · Fixed by #5741 or #5827
Labels
type:feature Feature. Required intentional design
Milestone
Target:2.1.2

Comments

@jvigliotta
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We currently sync changes from couch for a couple of object types, notably Notebooks.

Describe the solution you'd like
We need to add the object type for restricted notebooks as well.

Additional context
This was intended initially, we just missed this one.

Testing

#3784 (comment)
Same as above, except you will also want to lock notebook pages as well and verify that also syncs.
@jvigliotta jvigliotta self-assigned this Sep 30, 2022
@jvigliotta jvigliotta mentioned this issue Sep 30, 2022
Merged
15 tasks
@unlikelyzero unlikelyzero added this to the Target:2.1.2 milestone Sep 30, 2022
@jvigliotta jvigliotta mentioned this issue Sep 30, 2022
Merged
15 tasks
@jvigliotta jvigliotta modified the milestones: Target:2.1.2, Target:2.1.1 Sep 30, 2022
@unlikelyzero unlikelyzero added type:feature Feature. Required intentional design and removed type:enhancement labels Oct 7, 2022
@michaelrogers
Copy link
Contributor

Fix verified during testathon on 10/24/2022. After commiting a Notebook Shift Log, a second browser's status was synchronized as expected and locked from further changes.

@akhenry
Copy link
Contributor

akhenry commented Oct 27, 2022 •
edited

Verified fixed. Unfortunately conflict resolution is not working again in notebooks generally. Will file a separate issue. Added #5921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feature Feature. Required intentional design
Projects
None yet
Milestone
Target:2.1.2
6 participants
@akhenry @michaelrogers @ozyx @jvigliotta @unlikelyzero @rukmini-bose