Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search is case-sensitive when searching for YAMCS telemetry #5822

Closed
1 of 7 tasks
shefalijoshi opened this issue Sep 30, 2022 · 6 comments · Fixed by akhenry/openmct-yamcs#203
Closed
1 of 7 tasks

Search is case-sensitive when searching for YAMCS telemetry #5822

shefalijoshi opened this issue Sep 30, 2022 · 6 comments · Fixed by akhenry/openmct-yamcs#203
Assignees
@scottbell
Labels
severity:blocker type:bug
Milestone
Target:2.1.1

Comments

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Sep 30, 2022 •
edited by unlikelyzero

Summary

Search for something in Open MCT - like 'Navcam' or 'Hazcam'. Briefly, the results showed up and then I only see Annotations results.
Unable to search for telemetry

Expected vs Current Behavior

Telemetry as well as annotation results expected in search results.

Steps to Reproduce

  1. Ensure that tags are available on Open MCT
  2. Search for something like 'Navcam'
  3. Look at the search results
  4. Only annotation results are displayed

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

image
@unlikelyzero unlikelyzero added this to the Target:2.1.1 milestone Sep 30, 2022
@ozyx
Copy link
Member

ozyx commented Sep 30, 2022

It looks like it's case-sensitive for telemetry? Searching for "Hazcam" brings up the objects as expected.

@scottbell scottbell linked a pull request Oct 1, 2022 that will close this issue
Ignore case on search akhenry/openmct-yamcs#202
Closed
15 tasks
@scottbell scottbell mentioned this issue Oct 1, 2022
Closed
15 tasks
@scottbell
Copy link
Contributor

Yeah, the issue was we weren't ignoring case. I think the issue is fixed in the new PR:

Screen.Recording.2022-10-01.at.6.32.36.AM.mov

@scottbell scottbell mentioned this issue Oct 1, 2022
Merged
15 tasks
@scottbell
Copy link
Contributor

akhenry/openmct-yamcs#203

@scottbell scottbell removed a link to a pull request Oct 1, 2022
Ignore case on search akhenry/openmct-yamcs#202
Closed
15 tasks
@scottbell scottbell linked a pull request Oct 1, 2022 that will close this issue
Ignore case on YAMCS telemetry search akhenry/openmct-yamcs#203
Merged
15 tasks
@akhenry akhenry closed this as completed Oct 3, 2022
@akhenry
Copy link
Contributor

akhenry commented Oct 4, 2022

@ozyx to test

@ozyx ozyx changed the title Search results show only annotations results Search is case-sensitive when searching for YAMCS provided objects Oct 4, 2022
@ozyx ozyx changed the title Search is case-sensitive when searching for YAMCS provided objects Search is case-sensitive when searching for YAMCS telemetry Oct 4, 2022
@ozyx
Copy link
Member

ozyx commented Oct 4, 2022

Verified fixed Testathon 10/4/22

@ozyx ozyx added unverified and removed unverified labels Oct 4, 2022
@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon 10/4

@akhenry akhenry removed the unverified label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottbell scottbell

Labels
severity:blocker type:bug
Projects
None yet
Milestone
Target:2.1.1
6 participants
@akhenry @shefalijoshi @ozyx @scottbell @jvigliotta @unlikelyzero