Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go To Original should not be allowed from elements pool in edit mode #5847

Closed
1 of 7 tasks
davetsay opened this issue Oct 6, 2022 · 3 comments
Closed
1 of 7 tasks

Comments

@davetsay
Copy link
Contributor

davetsay commented Oct 6, 2022

Summary

If you are editing an object that has composition, clicking Go To Original action does a few very bad things.

  1. you leave the context of the object you're editing
  2. the object you've navigated to is viewed in edit mode, whether it is editable or not
  3. you cannot go back to the original object to save any edits that have been made (although you can save in the navigated object and the transaction for the original object does in fact save correctly).
  4. If the object you chose Go To Original action on had been added in edit mode, it is nested in the tree view but does not appear to be added to the original objects composition.

Doing this from the tree or from the elements pool is the same.

Expected vs Current Behavior

@charlesh88 What should happen here. We already have a open in new tab and view large action. I think the Go To Original action should be removed in this (in edit mode) context.

Steps to Reproduce

  1. drag an object into another object that supports editing and composition
  2. right click the added object in the elements pool, or right click on a tree item
  3. select Go To Original action
  4. Observe that have indeed navigated to that object and that openmct is still in edit mode

Environment

  • Open MCT Version: #release/2.1.1
  • Deployment Type: viper
  • OS: Mac
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@michaelrogers
Copy link
Contributor

How to test

  • drag an object into another object that supports editing and composition
  • right click the added object in the elements pool, or right click on a tree item
  • Observe the Go To Original action is visible in the context menu
  • Enter edit mode
  • Right click the tree item
  • Observe that the Go To Original action is no longer available

@akhenry
Copy link
Contributor

akhenry commented Dec 5, 2022

Verified fixed

@rukmini-bose
Copy link
Contributor

Verified Testathon 12/5/2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants