Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show me where I am zoomed within an image #5851

Closed
akhenry opened this issue Oct 6, 2022 · 5 comments · Fixed by #5877
Closed

Show me where I am zoomed within an image #5851

akhenry opened this issue Oct 6, 2022 · 5 comments · Fixed by #5877
Assignees
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Oct 6, 2022

Is your feature request related to a problem? Please describe.
When zoomed in an image, it would be useful to know where in the full image I am zoomed. This is particularly useful when locking zoom state and moving between images.

Describe the solution you'd like
When zoomed within an image, show a rectangle within a thumbnail of the full image indicating where I am zoomed. This could be overlaid on the existing image thumbnail, since we're already showing a thumbnail there.

Example
Screen Shot 2022-10-06 at 2 52 41 PM

@akhenry
Copy link
Contributor Author

akhenry commented Oct 6, 2022

@charlesh88 Thoughts?

@LuciNyan
Copy link
Contributor

I'd love to work on this issue! Could you please assign this to me if not been assigned to anybody yet? Thanks! <3

@ozyx ozyx added this to the 2.1.3 milestone Oct 24, 2022
@unlikelyzero unlikelyzero removed this from the Target:2.1.3 milestone Nov 15, 2022
@ozyx ozyx added this to the Target:2.1.4 milestone Nov 21, 2022
@ozyx ozyx added unverified needs:test instructions Missing testing notes labels Nov 21, 2022
@ozyx
Copy link
Member

ozyx commented Dec 5, 2022

Verified, Testathon 12/5/22:

Zoom indicator displays correctly when zoomed in and panned. It also applies to adjacent images if the zoom if locked. On window resize, the zoom area adjusts correctly. Awesome stuff.

@davetsay
Copy link
Contributor

davetsay commented Dec 5, 2022

verified

@davetsay
Copy link
Contributor

davetsay commented Dec 5, 2022

this is great @LuciNyan , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants