Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagery is auto-scrolling Display Layout on update #5867

Closed
5 of 7 tasks
charlesh88 opened this issue Oct 12, 2022 · 3 comments · Fixed by #5961
Closed
5 of 7 tasks

Imagery is auto-scrolling Display Layout on update #5867

charlesh88 opened this issue Oct 12, 2022 · 3 comments · Fixed by #5961

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Oct 12, 2022

Summary

When a Display Layout that has an imagery view with thumbnails is hidden behind a scroll:

Screen Shot 2022-10-11 at 5 18 12 PM

when that Imagery view updates to receive a new thumbnail the whole layout is automatically scrolled to bring the Imagery element frame into view:

Screen Shot 2022-10-11 at 5 18 18 PM

This occurs in the main view, and will occur in nested Display Layouts, with each child layout scrolling itself additionally:

Screen Shot 2022-10-11 at 5 32 46 PM

Expected vs Current Behavior

Jokes aside that this is a feature to bring changing things into view, the real problem here is that something the user is actually looking at may be scrolled out of view without them desiring that.

Steps to Reproduce

  1. Make or edit a Display Layout such that an imagery view that receives real-time updates is placed to the far right and lower edge of the canvas, ideally in a way that it can be hidden when the main view's horizontal scroll is all the way to the left and up. See the first attached image above.
  2. Size the browser window such that vertical/horizontal scrollbars appear for the main view area, and the imagery element is completely or mostly hidden behind the scroll. Adjust the position and size of that element accordingly.
  3. Save changes, nav away and then back to the main view. Observe: The view may be scrolled even on initial load. Important: don't touch the scroll in the main view - manually setting the scroll back seems to prevent the problem from occurring.
  4. Observe: when the Imagery view receives a new thumbnail update, the view will automatically scroll to bring it into view.

Environment

  • Open MCT Version: 2.1.2
  • Deployment Type: localhost
  • OS: MacOS
  • Browser: Chrome 105.0.5195.125 (Official Build) (x86_64)

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@charlesh88 charlesh88 changed the title Imagery thumb scroller is scrolling Display Layout on update Imagery is auto-scrolling Display Layout on update Oct 12, 2022
@unlikelyzero unlikelyzero added this to the Target:2.1.2 milestone Oct 12, 2022
@unlikelyzero unlikelyzero modified the milestones: Target:2.1.2, 2.1.3 Oct 27, 2022
@michaelrogers
Copy link
Contributor

How to test

  • Create a display layout
  • Add imagery to the layout
  • Position it to be outside the scroll area of the window
  • Switch to a realtime mode (Local Clock)
  • Observe that as new image telemetry streams in that the scroll area does not shift
  • Observe that the image thumbnails continue to scroll to the right to show the latest

@scottbell
Copy link
Contributor

scottbell commented Nov 16, 2022

Note for testing, the Imagery with the thumbnail strip has to be visible, so the imagery has be sized tall enough to have a thumbnail strip. E.g., you want this:
image
not this:
image

@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Dec 28, 2022
@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation Dec 28, 2022
@ozyx
Copy link
Member

ozyx commented Dec 28, 2022

Veriified Testathon 12/28/2022:

Imagery streams in, the imagery view in the display layout will scroll but the display layout itself does not. Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

6 participants